One ntp to rule#612
Open
MarlinMr wants to merge 1 commit into
Open
Conversation
MarlinMr
force-pushed
the
one-ntp-to-rule
branch
from
f403504 to
f7c0765
Compare
Contributor
Author
MarlinMr
force-pushed
the
one-ntp-to-rule
branch
from
f7c0765 to
f5b2b74
Compare
5 tasks
MarlinMr
force-pushed
the
one-ntp-to-rule
branch
from
f5b2b74 to
0302b6b
Compare
VVelox
requested changes
Mar 21, 2026
VVelox
left a comment
VVelox
left a comment
Collaborator
There was a problem hiding this comment.
Needs to be portable. Use a flag for which should be used.
MarlinMr
force-pushed
the
one-ntp-to-rule
branch
from
0302b6b to
f948c29
Compare
VVelox
requested changes
Mar 21, 2026
VVelox
left a comment
VVelox
left a comment
Collaborator
There was a problem hiding this comment.
Generally best to leave the old ones in place still if they work.
Collaborator
There was a problem hiding this comment.
Also we generally leave older versions of the extends laying around if they work in case any one has anything that depends on those as part of a ansible/rex job or the like.
MarlinMr
force-pushed
the
one-ntp-to-rule
branch
from
f948c29 to
ad2609a
Compare
MarlinMr
force-pushed
the
one-ntp-to-rule
branch
from
ad2609a to
a9f9e10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.