Fix the build for android gradle plugin 9.0.1#181
Conversation
Bumps com.android.tools.build:gradle from 8.13.2 to 9.0.1. --- updated-dependencies: - dependency-name: com.android.tools.build:gradle dependency-version: 9.0.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
|
Thanks for finding a workaround. Let this PR sit for a while while we look for "permanent" fix? |
|
I don't know... I saw in some blogs that for now there isn't any other fix. side note: I've just changed the base branch to master in the hope it would trigger CI, but apparently it didn't. |
|
I suggest: create an issue for the workaround, and update the comment to refer to the issue. The gradle.properties comment in this PR is oddly formatted, right? https://localizely.com/java-properties-file/ Updating the comment should trigger a build. |
|
oh oh :-) |
|
Can you verify that proguard w/optimization is not breaking anything?
|
|
well PdTest builds and runs normally. |
|
Looks good. Do you want to bump the minor version to make a new snapshot? |
|
Good idea. Even if API didn't change, if problems (e.g with proguard optimization) arise we can compare with 1.4.1. |
|
FYI PdDroidParty compiles and runs fine with 1.4.2-SNAPSHOT :-) |
this fixes pd-core build with a temporary fix:
and also fixes PdTest build error about Proguard, which now requires to replace
proguard-android.txtwithproguard-android-optimize.txt.