Skip to content

Fix the build for android gradle plugin 9.0.1#181

Merged
joebowbeer merged 5 commits intolibpd:masterfrom
Ant1r:fix-AGP9
Mar 1, 2026
Merged

Fix the build for android gradle plugin 9.0.1#181
joebowbeer merged 5 commits intolibpd:masterfrom
Ant1r:fix-AGP9

Conversation

@Ant1r
Copy link
Copy Markdown
Contributor

@Ant1r Ant1r commented Feb 28, 2026

this fixes pd-core build with a temporary fix:

android.newDsl=false

and also fixes PdTest build error about Proguard, which now requires to replace proguard-android.txt with proguard-android-optimize.txt.

Bumps com.android.tools.build:gradle from 8.13.2 to 9.0.1.

---
updated-dependencies:
- dependency-name: com.android.tools.build:gradle
  dependency-version: 9.0.1
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@Ant1r Ant1r changed the title Fix agp9 Fix the build for android gradle plugin 9.0.1 Feb 28, 2026
@joebowbeer
Copy link
Copy Markdown
Contributor

Thanks for finding a workaround. Let this PR sit for a while while we look for "permanent" fix?

@Ant1r Ant1r changed the base branch from dependabot/gradle/com.android.tools.build-gradle-9.0.1 to master February 28, 2026 19:58
@Ant1r
Copy link
Copy Markdown
Contributor Author

Ant1r commented Feb 28, 2026

I don't know... I saw in some blogs that for now there isn't any other fix.
Maybe this hack will stay for a while... a warning says that it will disappear in AGP 10.x, but it's only 9.0.1 now.

side note: I've just changed the base branch to master in the hope it would trigger CI, but apparently it didn't.

@joebowbeer
Copy link
Copy Markdown
Contributor

I suggest: create an issue for the workaround, and update the comment to refer to the issue.

The gradle.properties comment in this PR is oddly formatted, right?

https://localizely.com/java-properties-file/

Updating the comment should trigger a build.

@Ant1r
Copy link
Copy Markdown
Contributor Author

Ant1r commented Feb 28, 2026

oh oh :-)

@joebowbeer
Copy link
Copy Markdown
Contributor

Can you verify that proguard w/optimization is not breaking anything?

By using proguard-android-optimize.txt, you enable R8 to perform its full suite of optimizations, leading to a smaller, faster, and more efficient application. Note that enabling optimization can sometimes introduce new runtime issues, requiring careful testing and potentially adding specific -keep or -optimizations rules to your custom proguard-rules.pro file.

@Ant1r
Copy link
Copy Markdown
Contributor Author

Ant1r commented Feb 28, 2026

well PdTest builds and runs normally.

@joebowbeer
Copy link
Copy Markdown
Contributor

Looks good.

Do you want to bump the minor version to make a new snapshot?

@Ant1r
Copy link
Copy Markdown
Contributor Author

Ant1r commented Mar 1, 2026

Good idea. Even if API didn't change, if problems (e.g with proguard optimization) arise we can compare with 1.4.1.

Copy link
Copy Markdown
Contributor

@joebowbeer joebowbeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joebowbeer joebowbeer merged commit 189a1fb into libpd:master Mar 1, 2026
1 check passed
@Ant1r Ant1r deleted the fix-AGP9 branch March 1, 2026 22:00
@Ant1r
Copy link
Copy Markdown
Contributor Author

Ant1r commented Mar 3, 2026

FYI PdDroidParty compiles and runs fine with 1.4.2-SNAPSHOT :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants