Drop streams when closing the connection#217
Open
stormshield-fabs wants to merge 1 commit into
Open
Conversation
stormshield-fabs
force-pushed
the
drop-streams-when-closing
branch
from
4bcb29d to
4add714
Compare
Author
|
We have successfully tested this in our deployments but would be interested in feedback from the maintainers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #216
This MR copies the Go implementation by explicitly closing the streams when the
Connectiontransitions to theClosingstate.We implemented and tested this successfully in our application.
Another possible fix would be to revert 2bae656 but there might be specific reasons why this was introduced in the first place so we preferred mimicking the
Active::cleanupimplementation.