refactor: Shared to use internal mutability#197
Open
akaladarshi wants to merge 4 commits into
Open
Conversation
elenaf9
reviewed
Jan 27, 2025
elenaf9
left a comment
elenaf9
left a comment
Member
There was a problem hiding this comment.
Thank you for your PR @akaladarshi!
Some comments.
akaladarshi
force-pushed
the
akaladarshi/refactor-shared
branch
from
aabc8a2 to
f7ad5e9
Compare
Author
|
@elenaf9 Thanks for the review 🙏. I have removed the |
elenaf9
approved these changes
Feb 11, 2025
elenaf9
left a comment
elenaf9
left a comment
Member
There was a problem hiding this comment.
One comment, rest LGTM. Thank you for the follow-ups @akaladarshi!
cc @jxs: think this change is an improvement because it hides the mutex-locking logic behind the Shared type and prevents deadlocks that would otherwise been possible when trying to locking the Mutex re-entrantly. Are you okay with merging?
|
Will this be merged? @elenaf9 @akaladarshi ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #170
This PR changes:
Sharedstruct internally handles the mutex.Sharedstruct now hasinner: Arc<Mutex<SharedInner>>