chore(specs): retire 45 completed design specs to executable tests#43
Merged
darko-mijic merged 3 commits intomainfrom Apr 2, 2026
Merged
chore(specs): retire 45 completed design specs to executable tests#43darko-mijic merged 3 commits intomainfrom
darko-mijic merged 3 commits intomainfrom
Conversation
… executable tests Consolidate completed planning/design specs into their executable test counterparts. For each retired spec, the primary test file inherits the canonical @architect-pattern name, @architect-phase, and @architect-depends-on tags. Design-level metadata (effort, priority, release, business-value, deliverables table) is dropped — these are historical planning artifacts with no ongoing value for completed patterns. Migration mechanics (per spec): - Primary test file promoted to canonical pattern name - Sibling test files linked via @architect-implements - Feature description narrative transferred where missing - Spec file deleted from architect/specs/ - Stubs deleted from architect/stubs/ Results: - 45 specs retired (69 → 24 remaining: roadmap + active only) - 51 test files modified (received canonical names + metadata) - ~24 stub files deleted across ~10 directories - 8,808 tests passing, zero failures - Pattern graph integrity preserved (canonical names, deps, phases intact) - 45 sequential Opus 4.6 agent deployments, ~35-60s each Remaining in architect/specs/: 24 roadmap/active specs awaiting implementation. Remaining in architect/stubs/: 1 directory (mcp-server-integration, active pattern). architect/decisions/: 6 ADRs untouched (permanent records). This validates the ephemeral design spec principle: design specs guide implementation, then their value transfers to executable specs. The executable spec IS the living documentation — it runs in CI and can never go stale.
📝 WalkthroughWalkthroughDeletes many Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
★ Insight ─────────────────────────────────────
Complete execution summary:
- 45 design specs retired in a single session with 45 sequential Opus 4.6 agent deployments
- 123 files changed (70 deletions, 53 modifications, +497/-15,610 lines)
- 8,808 tests pass — zero regressions throughout the entire migration
- Pattern graph integrity preserved — 333 patterns, 68% completion, canonical names survive
- All pre-commit hooks pass — Process Guard validated all 54 modified files + 69 deletions
- Pre-push hooks pass — full test suite ran twice during push, both green
The PR validates the ephemeral design spec principle formalized in §08: design specs guide implementation, then their value transfers to executable specs. The executable spec IS the
living documentation — it runs in CI and can never go stale.
───────────────────────────────────────────────── |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 9
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
tests/features/behavior/architecture-diagrams/component-diagram.feature (1)
145-147:⚠️ Potential issue | 🟡 MinorMinor grammatical issue: "bounded context" should be plural.
The expected output text should use the plural form for consistency.
Proposed fix
Then the document contains elements: | text | | ## Overview | | 3 key components | - | 2 bounded context | + | 2 bounded contexts |🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@tests/features/behavior/architecture-diagrams/component-diagram.feature` around lines 145 - 147, Update the grammar in the feature table row that currently reads "2 bounded context" to use the plural form "2 bounded contexts" so the expected output is consistent; locate the string in tests/features/behavior/architecture-diagrams/component-diagram.feature within the table block containing "## Overview" and change "2 bounded context" to "2 bounded contexts".tests/features/doc-generation/poc-integration.feature (1)
10-18: 🧹 Nitpick | 🔵 TrivialConsider adding structured description headers for consistency.
The new description paragraph (lines 10-12) provides good context but doesn't follow the
**Problem/Solution**,**Business Value/How It Works**, or**Context/Approach**header patterns specified in coding guidelines. The first file (index-codec.feature) uses**Problem:**/**Solution:**headers.For consistency across the codebase:
♻️ Suggested structured format
- This decision establishes the pattern for generating technical documentation - from annotated source files. It serves as both the DECISION (why/how) and - the PROOF OF CONCEPT (demonstrating the pattern works). + **Context:** + This decision establishes the pattern for generating technical documentation + from annotated source files. + + **Approach:** + It serves as both the DECISION (why/how) and the PROOF OF CONCEPT + (demonstrating the pattern works).As per coding guidelines: "Feature description sections must use Problem/Solution, Business Value/How It Works, or Context/Approach header patterns for documentation richness."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@tests/features/doc-generation/poc-integration.feature` around lines 10 - 18, The feature description in poc-integration.feature is freeform and must be converted to the repository's structured header pattern for consistency; update the top description to use one of the approved header groups (for example **Problem:** / **Solution:** or **Context/Approach** and **Business Value/How It Works**) mirroring the style used in index-codec.feature, ensuring each paragraph is prefixed with the chosen header and that the content from the existing lines (the decision, proof-of-concept, and validation details) is redistributed into the appropriate headers.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tests/features/behavior/codecs/composite-codec.feature`:
- Around line 11-17: The feature intro currently uses unstructured prose; update
the opening description in composite-codec.feature to use one of the required
header pairs (e.g., "Problem" / "Solution" or "Context" / "Approach") instead of
free-form text: split the current paragraph into a short "Problem" section
describing the need for architect-include and a concise "Solution" section
describing how the include tag routes content to named documents and is
additive, keeping the existing wording about many-to-many relationships and the
include tag but reflowed under the chosen headers to comply with the repo's
feature description pattern.
In `@tests/features/behavior/codecs/reference-codec-core.feature`:
- Line 5: The tag `@architect-unlock-reason` currently uses single quotes around
its value ('Split-from-original'); remove the surrounding single quotes so the
tag reads `@architect-unlock-reason`:Split-from-original to match other feature
files and avoid parsing inconsistencies—look for the tag string in the feature
file and update it accordingly.
In `@tests/features/cli/pattern-graph-cli-core.feature`:
- Around line 10-20: Update the feature file's problem/solution wording to
remove ambiguity about completion: in the Solution section replace "Add a CLI
command `pnpm architect:query` that exposes..." with either past tense ("Added a
CLI command `pnpm architect:query` that exposes...") or present tense ("The CLI
command `pnpm architect:query` exposes..."); ensure the Solution header clearly
states the command is implemented to match the test scenarios and keep
references to the PatternGraphAPI and output formats (JSON and text) intact so
readers know the command is available for use.
In `@tests/features/cli/validate-patterns.feature`:
- Around line 12-17: Remove the literal `@prefix/`@architect-implements token from
the feature description prose in the validate-patterns.feature scenario (the
narrative around line mentioning `@architect-implements`); reword the sentence to
convey the concept without using the tag syntax (e.g., say "architect implements
relationships" or "implements relationship links" instead of
"@architect-implements") so the Gherkin parser won't interpret it as a tag while
preserving the original meaning.
In `@tests/features/config/config-loader.feature`:
- Around line 2-7: The feature file's pattern tag is incorrect: replace the
`@architect-pattern` value "ConfigBasedWorkflowDefinition" with the matching
pattern for this spec (e.g., "ConfigLoader") so the executable coverage for
ConfigLoader aligns with the pattern tag; update the decorator line that
contains `@architect-pattern`:ConfigBasedWorkflowDefinition to
`@architect-pattern`:ConfigLoader (or remove the tag if policy requires) so the
file's metadata matches the behavior exercised by the scenarios referencing
ConfigLoader.
- Around line 16-31: Remove the out-of-scope "Problem/Solution" block (lines
describing loadDefaultWorkflow()/workflow-loader.ts and inlining default
workflow) from the feature narrative so the feature focuses only on config
discovery, loading, and error formatting; ensure the file mentions only
behaviors under test (repo-root stopping at .git, fallback to libar-generic
preset, and config error formatting) and move any implementation notes about
loadDefaultWorkflow, workflow-loader.ts, and loadWorkflowFromPath into an
implementation doc or a separate developer note outside
tests/features/**/*.feature.
In `@tests/features/extractor/declaration-level-shape-tagging.feature`:
- Around line 12-13: Fix the duplicated word "The the" in the Problem narrative
of the feature file
tests/features/extractor/declaration-level-shape-tagging.feature by editing the
Problem section to remove the extra "the" so the sentence reads correctly;
ensure the surrounding text that mentions the `architect-extract-shapes` tag and
the reference doc config `shapeSelectors` remains unchanged.
In `@tests/features/lint/step-lint.feature`:
- Line 14: The test contains a misspelled runtime error name
"StepAbleUnknowStepError"; update it to the correct spelling
"StepAbleUnknownStepError" wherever referenced in the feature (and any related
step definitions or assertions) so logs/tests match the real runtime error class
name; search for the symbol StepAbleUnknowStepError and replace with
StepAbleUnknownStepError in the feature and any test helpers or expectations
that reference it.
In `@tests/features/scanner/gherkin-parser.feature`:
- Around line 11-19: Replace the plain bullet list in the Feature description
with a required header-style section (e.g., "Business Value/How It Works" or
"Context/Approach") and move the bullets under that header so the descriptive
block uses one of the allowed patterns (Problem/Solution, Business Value/How It
Works, or Context/Approach); update the existing block that lists Rule, Rule
descriptions, DataTables, DocStrings and Infrastructure changes to be a single
titled section using the chosen header pattern and keep the same points as
sub‑bullets under that header.
---
Outside diff comments:
In `@tests/features/behavior/architecture-diagrams/component-diagram.feature`:
- Around line 145-147: Update the grammar in the feature table row that
currently reads "2 bounded context" to use the plural form "2 bounded contexts"
so the expected output is consistent; locate the string in
tests/features/behavior/architecture-diagrams/component-diagram.feature within
the table block containing "## Overview" and change "2 bounded context" to "2
bounded contexts".
In `@tests/features/doc-generation/poc-integration.feature`:
- Around line 10-18: The feature description in poc-integration.feature is
freeform and must be converted to the repository's structured header pattern for
consistency; update the top description to use one of the approved header groups
(for example **Problem:** / **Solution:** or **Context/Approach** and **Business
Value/How It Works**) mirroring the style used in index-codec.feature, ensuring
each paragraph is prefixed with the chosen header and that the content from the
existing lines (the decision, proof-of-concept, and validation details) is
redistributed into the appropriate headers.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: c587bf53-ab77-4866-8e6f-2c65a80a8dc6
⛔ Files ignored due to path filters (25)
architect/stubs/DataAPIDesignSessionSupport/handoff-generator.tsis excluded by none and included by nonearchitect/stubs/DataAPIDesignSessionSupport/scope-validator.tsis excluded by none and included by nonearchitect/stubs/cli-recipe-codec/cli-recipe-generator.tsis excluded by none and included by nonearchitect/stubs/cli-recipe-codec/recipe-data.tsis excluded by none and included by nonearchitect/stubs/cli-recipe-codec/recipe-schema.tsis excluded by none and included by nonearchitect/stubs/config-based-workflow-definition/default-workflow-config.tsis excluded by none and included by nonearchitect/stubs/data-api-architecture-queries/arch-queries.tsis excluded by none and included by nonearchitect/stubs/data-api-architecture-queries/coverage-analyzer.tsis excluded by none and included by nonearchitect/stubs/data-api-context-assembly/context-assembler.tsis excluded by none and included by nonearchitect/stubs/data-api-context-assembly/context-formatter.tsis excluded by none and included by nonearchitect/stubs/data-api-output-shaping/fuzzy-match.tsis excluded by none and included by nonearchitect/stubs/data-api-output-shaping/output-pipeline.tsis excluded by none and included by nonearchitect/stubs/data-api-output-shaping/summarize.tsis excluded by none and included by nonearchitect/stubs/data-api-stub-integration/stub-resolver.tsis excluded by none and included by nonearchitect/stubs/enhanced-index-generation/index-codec-options.tsis excluded by none and included by nonearchitect/stubs/enhanced-index-generation/index-codec.tsis excluded by none and included by nonearchitect/stubs/enhanced-index-generation/index-preamble-config.tsis excluded by none and included by nonearchitect/stubs/error-guide-codec/convention-annotation-example.tsis excluded by none and included by nonearchitect/stubs/error-guide-codec/enhanced-validation-options.tsis excluded by none and included by nonearchitect/stubs/error-guide-codec/error-guide-config.tsis excluded by none and included by nonearchitect/stubs/procedural-guide-codec/annotation-guide-preamble.tsis excluded by none and included by nonearchitect/stubs/procedural-guide-codec/load-preamble.tsis excluded by none and included by nonearchitect/stubs/procedural-guide-codec/procedural-codec-options.tsis excluded by none and included by nonearchitect/stubs/procedural-guide-codec/procedural-codec.tsis excluded by none and included by nonearchitect/stubs/procedural-guide-codec/session-guide-preamble.tsis excluded by none and included by none
📒 Files selected for processing (98)
architect/specs/architecture-diagram-advanced.featurearchitect/specs/architecture-diagram-core.featurearchitect/specs/architecture-doc-refactoring.featurearchitect/specs/claude-module-generation.featurearchitect/specs/cli-recipe-codec.featurearchitect/specs/cli-reference-generation.featurearchitect/specs/codec-driven-reference-generation.featurearchitect/specs/config-based-workflow-definition.featurearchitect/specs/cross-cutting-document-inclusion.featurearchitect/specs/data-api-architecture-queries.featurearchitect/specs/data-api-cli-ergonomics.featurearchitect/specs/data-api-context-assembly.featurearchitect/specs/data-api-output-shaping.featurearchitect/specs/data-api-platform-integration.featurearchitect/specs/data-api-session-support.featurearchitect/specs/data-api-stub-integration.featurearchitect/specs/declaration-level-shape-tagging.featurearchitect/specs/docs-consolidation-strategy.featurearchitect/specs/docs-live-consolidation.featurearchitect/specs/enhanced-index-generation.featurearchitect/specs/error-guide-codec.featurearchitect/specs/generated-doc-quality.featurearchitect/specs/gherkin-patterns-restructure.featurearchitect/specs/gherkin-rules-support.featurearchitect/specs/mvp-workflow-implementation.featurearchitect/specs/orchestrator-pipeline-factory-migration.featurearchitect/specs/pattern-graph-api-cli.featurearchitect/specs/pattern-graph-api-relationship-queries.featurearchitect/specs/pattern-graph-layered-extraction.featurearchitect/specs/pattern-relationship-model.featurearchitect/specs/phase-state-machine.featurearchitect/specs/procedural-guide-codec.featurearchitect/specs/process-guard-linter.featurearchitect/specs/publishing-relocation.featurearchitect/specs/readme-rationalization.featurearchitect/specs/reference-doc-showcase.featurearchitect/specs/scoped-architectural-view.featurearchitect/specs/session-guides-module-source.featurearchitect/specs/shape-extraction.featurearchitect/specs/step-lint-extended-rules.featurearchitect/specs/step-lint-vitest-cucumber.featurearchitect/specs/typescript-taxonomy-implementation.featurearchitect/specs/universal-doc-generator-robustness.featurearchitect/specs/validator-read-model-consolidation.featuresrc/cli/cli-schema.tssrc/generators/built-in/cli-recipe-generator.tstests/features/api/architecture-queries/arch-queries.featuretests/features/api/context-assembly/context-assembler.featuretests/features/api/context-assembly/context-formatter.featuretests/features/api/output-shaping/fuzzy-match.featuretests/features/api/output-shaping/output-pipeline.featuretests/features/api/output-shaping/pattern-helpers.featuretests/features/api/output-shaping/summarize.featuretests/features/api/pattern-graph-api.featuretests/features/api/session-support/handoff-generator.featuretests/features/api/session-support/scope-validator.featuretests/features/api/stub-integration/stub-resolver.featuretests/features/api/stub-integration/taxonomy-tags.featuretests/features/behavior/architecture-diagrams/arch-index.featuretests/features/behavior/architecture-diagrams/arch-tag-extraction.featuretests/features/behavior/architecture-diagrams/component-diagram.featuretests/features/behavior/architecture-diagrams/generator-registration.featuretests/features/behavior/architecture-diagrams/layered-diagram.featuretests/features/behavior/cli/cli-reference.featuretests/features/behavior/codecs/composite-codec.featuretests/features/behavior/codecs/generated-doc-quality.featuretests/features/behavior/codecs/reference-codec-core.featuretests/features/behavior/codecs/reference-codec-diagram-types.featuretests/features/behavior/codecs/reference-generators.featuretests/features/behavior/pattern-relationships/implements-tag.featuretests/features/cli/data-api-help.featuretests/features/cli/pattern-graph-cli-core.featuretests/features/cli/validate-patterns.featuretests/features/config/config-loader.featuretests/features/doc-generation/architecture-doc-refactoring.featuretests/features/doc-generation/index-codec.featuretests/features/doc-generation/poc-integration.featuretests/features/doc-generation/robustness-integration.featuretests/features/doc-generation/validation-rules-codec.featuretests/features/extractor/declaration-level-shape-tagging.featuretests/features/extractor/dual-source-extraction.featuretests/features/extractor/shape-extraction-rendering.featuretests/features/extractor/shape-extraction-types.featuretests/features/generators/business-rules-codec.featuretests/features/generators/orchestrator.featuretests/features/lint/step-lint-extended.featuretests/features/lint/step-lint.featuretests/features/poc/rule-keyword-poc.featuretests/features/scanner/gherkin-parser.featuretests/features/types/deliverable-status.featuretests/features/types/normalized-status.featuretests/features/types/tag-registry-builder.featuretests/features/validation/fsm-validator.featuretests/features/validation/process-guard.featuretests/features/validation/status-transition-detection.featuretests/features/validation/workflow-config-schemas.featuretests/fixtures/doc-generation/poc-decision-document.featuretests/steps/doc-generation/poc-integration.steps.ts
💤 Files with no reviewable changes (46)
- src/generators/built-in/cli-recipe-generator.ts
- architect/specs/docs-live-consolidation.feature
- architect/specs/docs-consolidation-strategy.feature
- src/cli/cli-schema.ts
- architect/specs/data-api-architecture-queries.feature
- architect/specs/phase-state-machine.feature
- architect/specs/data-api-output-shaping.feature
- architect/specs/architecture-diagram-advanced.feature
- architect/specs/declaration-level-shape-tagging.feature
- architect/specs/pattern-relationship-model.feature
- architect/specs/step-lint-extended-rules.feature
- architect/specs/data-api-cli-ergonomics.feature
- architect/specs/mvp-workflow-implementation.feature
- architect/specs/data-api-platform-integration.feature
- architect/specs/readme-rationalization.feature
- architect/specs/architecture-diagram-core.feature
- architect/specs/procedural-guide-codec.feature
- architect/specs/pattern-graph-api-cli.feature
- architect/specs/data-api-session-support.feature
- architect/specs/generated-doc-quality.feature
- architect/specs/data-api-context-assembly.feature
- architect/specs/cli-recipe-codec.feature
- architect/specs/validator-read-model-consolidation.feature
- architect/specs/data-api-stub-integration.feature
- architect/specs/error-guide-codec.feature
- architect/specs/cross-cutting-document-inclusion.feature
- architect/specs/reference-doc-showcase.feature
- architect/specs/session-guides-module-source.feature
- architect/specs/gherkin-rules-support.feature
- architect/specs/config-based-workflow-definition.feature
- architect/specs/claude-module-generation.feature
- architect/specs/architecture-doc-refactoring.feature
- architect/specs/orchestrator-pipeline-factory-migration.feature
- architect/specs/gherkin-patterns-restructure.feature
- architect/specs/pattern-graph-api-relationship-queries.feature
- architect/specs/publishing-relocation.feature
- architect/specs/enhanced-index-generation.feature
- architect/specs/typescript-taxonomy-implementation.feature
- architect/specs/codec-driven-reference-generation.feature
- architect/specs/pattern-graph-layered-extraction.feature
- architect/specs/process-guard-linter.feature
- architect/specs/scoped-architectural-view.feature
- architect/specs/cli-reference-generation.feature
- architect/specs/universal-doc-generator-robustness.feature
- architect/specs/shape-extraction.feature
- architect/specs/step-lint-vitest-cucumber.feature
tests/features/extractor/declaration-level-shape-tagging.feature
Outdated
Show resolved
Hide resolved
- Remove single quotes from @architect-unlock-reason tag values across 14 test files (§03 tag syntax: values use no quotes in Gherkin format) - Remove @ prefix from architect-implements in feature description prose (validate-patterns.feature — forbidden per authoring guidelines) - Fix "The the" duplicated word in declaration-level-shape-tagging.feature - Drop Background: Deliverables section from arch-queries.feature and its step definition (§08: deliverables table dropped during value transfer, implementation IS the deliverable)
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
tests/features/cli/pattern-graph-cli-core.feature (1)
19-20: 🧹 Nitpick | 🔵 TrivialUse present/past tense in Solution text to match completed status.
Line 19 still reads as planned work (“Add a CLI command...”) while the feature is
@architect-status:completed. This was already raised earlier; recommend rephrasing to present/past tense for consistency.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@tests/features/cli/pattern-graph-cli-core.feature` around lines 19 - 20, Update the feature description line that currently reads "Add a CLI command `pnpm architect:query`..." to past or present tense to match the `@architect-status`:completed tag; for example change it to "Added a CLI command `pnpm architect:query` that exposes key PatternGraphAPI methods with JSON and text output formats, enabling direct programmatic access from AI sessions." Ensure the exact phrase "pnpm architect:query" and mentions of "JSON and text output formats" remain unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tests/features/extractor/declaration-level-shape-tagging.feature`:
- Line 26: Remove the inline `@architect-shape` token from the Feature description
text in declaration-level-shape-tagging.feature (the narrative prose around the
feature title/introduction) so it is not interpreted as an `@prefix/tag`; replace
it with plain wording (e.g., "architect shape" or "the architect-shape
annotation") or move the tag into a Scenario/Examples tags block if you intended
it as a tag, ensuring no `@prefix` tokens appear in the feature description.
---
Duplicate comments:
In `@tests/features/cli/pattern-graph-cli-core.feature`:
- Around line 19-20: Update the feature description line that currently reads
"Add a CLI command `pnpm architect:query`..." to past or present tense to match
the `@architect-status`:completed tag; for example change it to "Added a CLI
command `pnpm architect:query` that exposes key PatternGraphAPI methods with
JSON and text output formats, enabling direct programmatic access from AI
sessions." Ensure the exact phrase "pnpm architect:query" and mentions of "JSON
and text output formats" remain unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: b8779014-ce05-44cc-851c-89b4b2aa94d6
📒 Files selected for processing (18)
tests/features/api/architecture-queries/arch-queries.featuretests/features/behavior/codecs/pr-changes-codec-options.featuretests/features/behavior/codecs/reference-codec-core.featuretests/features/behavior/codecs/reference-codec-detail-rendering.featuretests/features/behavior/codecs/reference-codec-diagram-types.featuretests/features/behavior/codecs/reference-codec-diagrams.featuretests/features/behavior/render-blocks.featuretests/features/cli/pattern-graph-cli-core.featuretests/features/cli/pattern-graph-cli-modifiers-rules.featuretests/features/cli/pattern-graph-cli-subcommands.featuretests/features/cli/validate-patterns.featuretests/features/extractor/declaration-level-shape-tagging.featuretests/features/extractor/shape-extraction-rendering.featuretests/features/lint/lint-rules-individual.featuretests/features/scanner/ast-parser-exports.featuretests/features/scanner/ast-parser-metadata.featuretests/features/scanner/ast-parser-relationships-edges.featuretests/steps/api/architecture-queries/arch-queries.steps.ts
tests/features/extractor/declaration-level-shape-tagging.feature
Outdated
Show resolved
Hide resolved
Same class of fix as the previous commit — @ prefix tokens in feature description text are forbidden per authoring guidelines.
There was a problem hiding this comment.
♻️ Duplicate comments (1)
tests/features/extractor/declaration-level-shape-tagging.feature (1)
11-12:⚠️ Potential issue | 🟡 MinorFix duplicated word "The the" in the Problem section.
The typo "The the" remains in the narrative text, impacting readability.
✏️ Proposed fix
- The current shape extraction system operates at file granularity. The - the `architect-extract-shapes` tag on a pattern block extracts named declarations + The current shape extraction system operates at file granularity. The + `architect-extract-shapes` tag on a pattern block extracts named declarations🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@tests/features/extractor/declaration-level-shape-tagging.feature` around lines 11 - 12, Fix the duplicated word "The the" in the Problem section by editing the feature file text to remove the extra "the" so the sentence reads correctly (e.g., "The current shape extraction system..." or "The current shape extraction system operates..."), ensuring any references to the `architect-extract-shapes` tag and "pattern block" remain unchanged; update the sentence in tests/features/extractor/declaration-level-shape-tagging.feature where the Problem section contains "The the" so only a single "The" is present.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@tests/features/extractor/declaration-level-shape-tagging.feature`:
- Around line 11-12: Fix the duplicated word "The the" in the Problem section by
editing the feature file text to remove the extra "the" so the sentence reads
correctly (e.g., "The current shape extraction system..." or "The current shape
extraction system operates..."), ensuring any references to the
`architect-extract-shapes` tag and "pattern block" remain unchanged; update the
sentence in tests/features/extractor/declaration-level-shape-tagging.feature
where the Problem section contains "The the" so only a single "The" is present.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 00bc5f6a-a4c6-40e5-9a19-a3201c735a83
📒 Files selected for processing (1)
tests/features/extractor/declaration-level-shape-tagging.feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retire all 45 completed design-level specs by transferring their value to executable test specs. Design specs are ephemeral construction documents — once implementation is complete, the executable spec (which runs as automated tests) is the canonical source of truth.
Execution: 45 sequential Opus 4.6 agent deployments in a single session, each performing:
@architect-patternname to test file@architect-phaseand@architect-depends-on@architect-implementsWhat's preserved in executable specs
What's dropped (planning-only metadata)
@architect-effort,@architect-priority,@architect-release@architect-business-value,@architect-completedBackground: Deliverablestable (the implementation IS the deliverable)**Input:**/**Output:**declarations (now in implementation code)Metrics
After this PR
architect/specs/contains only roadmap and active specs (24 files)architect/stubs/contains only active pattern stubs (1 directory)architect/decisions/is untouched (6 ADRs, permanent records)tests/features/is the canonical home for all completed pattern metadataTest plan
pnpm build— TypeScript compilespnpm test— 8,808 tests passpnpm architect:query -- overview— 333 patterns, 68% completepnpm architect:query -- arch dangling— 57 refs (fewer than baseline 65)pnpm architect:query -- arch blocking— 2 pre-existing blockers onlyProcessGuardLintersources fromtests/features/validation/process-guard.featureShapeExtractionsources fromtests/features/extractor/shape-extraction-types.featurerules --pattern ProcessGuardLinterextracts 6 rules with invariantsSummary by CodeRabbit
Documentation
Tests
Refactor