fix: add JSON omitempty and omitzero tags to asyncapiv3 types#286
Open
justenstall wants to merge 1 commit intolerenn:mainfrom
Open
fix: add JSON omitempty and omitzero tags to asyncapiv3 types#286justenstall wants to merge 1 commit intolerenn:mainfrom
justenstall wants to merge 1 commit intolerenn:mainfrom
Conversation
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
Owner
|
Sorry about the delay, I had some changes in my life this 2 past months, I'll take a look ASAP. |
|
Fixes also #300 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
omitemptyandomitzeroto the JSON struct tags for any fields that are not required according to the AsyncAPI specification. Some fields required the neweromitzerotag to be excluded without changing them to a pointer type, but I usedomitemptyfor every other field for maximum backwards compatibility.There is also a bug fix for the
Operation.Descriptionfield, which was set to usestringas its name in JSON.I documented that the
MessageTrait.Payloadfield should probably be removed, but kept it for now.I also documented some nuances with the interpretation of the
Operation.Messagesfield.