Skip to content

Improve key entry management, KeyStore UX, KeePass integration and UI infrastructure#26

Merged
Maxhy merged 5 commits into
leosac:developfrom
aurelm-w:develop
Jun 14, 2026
Merged

Improve key entry management, KeyStore UX, KeePass integration and UI infrastructure#26
Maxhy merged 5 commits into
leosac:developfrom
aurelm-w:develop

Conversation

@aurelm-w

Copy link
Copy Markdown
Contributor

This PR introduces several usability, filtering, and workflow improvements across key entry management, KeyStore integration, and KeePass module. It also includes : UI refinements, helper refactoring, dependency adjustments, and improvements to KeyStore lifecycle handling.

  • Key entry filtering and selection :
    • Added support for selecting only currently visible entries while clearing previous selections
    • Added support for extending the current selection with visible entries while preserving previously selected entries
    • Improved bulk-selection behavior when working with filtered key entry lists
    • Updated key entry view models and related UI components to provide more predictable selection behavior
    • Improved distinction between visible and global selection counts
    • Fixed selection consistency when filters are applied or removed
    • Ensured selection state remains coherent while navigating filtered results
  • KeyStore workflow improvements :
    • Added additional validation around KeyStore UI creation
    • Added clearer logging and error reporting for unsupported configurations
    • Improved robustness of KeyStore navigation and lifecycle management
    • Improved KeyStore opening and initialization flow
    • Improved handling of KeyStore user notifications
    • Prevented duplicate notification handler registrations when switching between KeyStores
  • UI improvements :
    • Added GreaterThanZeroConverter for count-based visibility and state bindings
    • Added ZeroToNullConverter for badge and counter display scenarios
    • Updated bindings to simplify count, badge and selection-related UI behavior
    • Applied several UI and interaction improvements in dialogs and related controls
  • KeePass improvements :
  • Refactoring and maintenance :
    • Improved readability, diagnostics and maintainability across affected components
    • Moved DialogHelper into the shared UI helpers namespace
    • Moved shared helper logic into appropriate common location
    • Reduced code duplication and simplified command logic
    • Performed cleanup and modernization in legacy dialog and XAML code
  • Dependencies :
    • Updated application dependencies and supporting components where required
    • Reverted library updates that introduced regressions or compatibility issues

@codacy-production

codacy-production Bot commented Jun 12, 2026

Copy link
Copy Markdown

Not up to standards ⛔

🔴 Issues 1 medium

Alerts:
⚠ 1 issue (≤ 0 issues of at least minor severity)

Results:
1 new issue

Category Results
Performance 1 medium

View in Codacy

🟢 Metrics 22 complexity · 0 duplication

Metric Results
Complexity 22
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@Maxhy Maxhy self-requested a review June 14, 2026 04:18

@Maxhy Maxhy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok good to me. Thanks for all these changes.
We will ignore the Codacy warning, still better than before.

@Maxhy Maxhy merged commit 11516ea into leosac:develop Jun 14, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants