Skip to content

Introduced reusable header control and improved MVVM architecture#25

Merged
Maxhy merged 3 commits into
leosac:developfrom
aurelm-w:develop
Jun 5, 2026
Merged

Introduced reusable header control and improved MVVM architecture#25
Maxhy merged 3 commits into
leosac:developfrom
aurelm-w:develop

Conversation

@aurelm-w

@aurelm-w aurelm-w commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

This PR refactors the Key Entries UI by extracting the toolbar responsibilities into a dedicated UI and VM, as requested in #11 .
This improves separation of concerns, reduces duplication and also makes the Key Entries view more maintainable and scalable.

  • Encapsulates all toolbar-related UI inside KeyEntriesHeaderControl
  • KeyEntriesHeaderViewModel acts as a proxy over KeyEntriesControlViewModel
  • Commands and properties are forwarded through the header VM
  • EditKeyStoreControlViewModel now propagates sticky header state across tabs and adds IsToolbarCollapsed tracking
  • Header control scroll position updates VM state
  • Added KeyEntryDeletionHandler to centralize deletion behavior
  • Refactors dialog closed handling in UI layer
  • Changed search action to MVVM command
  • Reduced XAML complexity in KeyEntriesControl
  • Improved refresh and loading state management

@codacy-production

codacy-production Bot commented Jun 5, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 28 complexity · 0 duplication

Metric Results
Complexity 28
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@Maxhy Maxhy self-requested a review June 5, 2026 13:56
@Maxhy Maxhy merged commit 0e831de into leosac:develop Jun 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants