Sprite.prototype.toNumber(value, true) - strict cast to number#203
Merged
adroitwhiz merged 1 commit intoleopard-js:masterfrom Jan 15, 2026
Merged
Sprite.prototype.toNumber(value, true) - strict cast to number#203adroitwhiz merged 1 commit intoleopard-js:masterfrom
adroitwhiz merged 1 commit intoleopard-js:masterfrom
Conversation
PullJosh
approved these changes
Jul 9, 2024
adroitwhiz
approved these changes
Jul 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supporting PR for leopard-js/sb-edit#149 or leopard-js/sb-edit#150.
Note during code review -
Number.isNaNchecks if its paremeter is literally the valueNaN.isNaNchecks if it'sNaNor it's not a number primitive at all. We've removed a usage ofisNaN, though there's no effective difference for the actual predicate value of that condition, since it used to be behind atypeof value === "number"check anyway.