Skip to content

Conversation

@neelr
Copy link

@neelr neelr commented Oct 3, 2020

fixes #83

@ghost
Copy link

ghost commented Oct 3, 2020

Sider detected 4 warnings on analyzing the commit 5095fe7.

We recommend fixing them as possible by updating the dependencies, configuring the analysis tool, configuring sider.yml, turning off unused tools, and so on.

If you have problems or questions still, feel free to ask us via chat. 💬


You can turn off this notification if you don't want to receive it from now on.

@neelr
Copy link
Author

neelr commented Oct 3, 2020

I think the check is wrong because it's looking for another quotation mark, when its just an apostrophe in an MD file


Thinking of adding a new feature? Cool! [Open an issue](https://github.com/leomvit/leomvit.github.io/issues) and let’s design it together.

**Thanks to [default](https://github.com/kennethormandy/default) for the template!**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @neelr . Thanks for adding this file! @AvikantSrivastava just added a pull request template and an issue template to this project (see #93 ). Can you mention those somewhere here, instead of the default template? Also I am requesting an additional review from @AvikantSrivastava , he may just want you to add specific details relevant to the project or the community if necessary.

@cseas cseas added waiting for author Waiting for a response from the original author review-requested A review from one of the maintainers is requested labels Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-requested A review from one of the maintainers is requested waiting for author Waiting for a response from the original author

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create a CONTRIBUTING.md file

3 participants