Skip to content

fix: make sure AbstracNestedProofs.visit doesn't fail due to transparency issues#12740

Closed
arthur-adjedj wants to merge 4 commits intoleanprover:masterfrom
arthur-adjedj:abstractNestedFix
Closed

fix: make sure AbstracNestedProofs.visit doesn't fail due to transparency issues#12740
arthur-adjedj wants to merge 4 commits intoleanprover:masterfrom
arthur-adjedj:abstractNestedFix

Conversation

@arthur-adjedj
Copy link
Contributor

@arthur-adjedj arthur-adjedj commented Feb 28, 2026

This PR ensures the isNonTrivialProof call in AbstracNestedProofs.visit runs with enough transparency to not trigger errors during its potential inferType call. This is needed when abstracting over proofs that may be needed to reduce a structurally recursive function eliminating from Prop to Type.

In preparation for #12718.

@arthur-adjedj
Copy link
Contributor Author

!bench mathlib

@leanprover-radar
Copy link

leanprover-radar commented Feb 28, 2026

Benchmark results for leanprover-community/mathlib4-nightly-testing@3898df9 against leanprover-community/mathlib4-nightly-testing@d448452 are in! @arthur-adjedj

  • build//instructions: -24.8G (-0.01%)

No significant changes detected.

@arthur-adjedj
Copy link
Contributor Author

changelog-language

@github-actions github-actions bot added the changelog-language Language features and metaprograms label Feb 28, 2026
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Feb 28, 2026
@leanprover-bot
Copy link
Collaborator

Reference manual CI status:

  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2026-02-25 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2026-02-28 18:47:49)

mathlib-nightly-testing bot pushed a commit to leanprover-community/batteries that referenced this pull request Feb 28, 2026
@github-actions github-actions bot added the mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN label Feb 28, 2026
mathlib-nightly-testing bot pushed a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Feb 28, 2026
@mathlib-lean-pr-testing mathlib-lean-pr-testing bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Feb 28, 2026
@mathlib-lean-pr-testing
Copy link

Mathlib CI status (docs):

@nomeata
Copy link
Collaborator

nomeata commented Feb 28, 2026

The test suite is currently revamped by @Garmelon, that could be related.

@nomeata
Copy link
Collaborator

nomeata commented Mar 2, 2026

Thanks for this fix. As discussed privately, this change is possibly, maybe even likely, benign, but touches a core component with a big blast radius, and reducibility issues are always hairy, so I cannot vouch for this change and the existing motivation (issue #12739) is not quite strong enough to take the risks or to spend more time thinking about it.

@nomeata nomeata closed this Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

builds-mathlib CI has verified that Mathlib builds against this PR changelog-language Language features and metaprograms mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants