fix: make sure AbstracNestedProofs.visit doesn't fail due to transparency issues#12740
Closed
arthur-adjedj wants to merge 4 commits intoleanprover:masterfrom
Closed
fix: make sure AbstracNestedProofs.visit doesn't fail due to transparency issues#12740arthur-adjedj wants to merge 4 commits intoleanprover:masterfrom
AbstracNestedProofs.visit doesn't fail due to transparency issues#12740arthur-adjedj wants to merge 4 commits intoleanprover:masterfrom
Conversation
Contributor
Author
|
!bench mathlib |
|
Benchmark results for leanprover-community/mathlib4-nightly-testing@3898df9 against leanprover-community/mathlib4-nightly-testing@d448452 are in! @arthur-adjedj
No significant changes detected. |
Contributor
Author
|
changelog-language |
Collaborator
|
Reference manual CI status:
|
mathlib-nightly-testing bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Feb 28, 2026
mathlib-nightly-testing bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Feb 28, 2026
|
Mathlib CI status (docs):
|
Collaborator
|
The test suite is currently revamped by @Garmelon, that could be related. |
Collaborator
|
Thanks for this fix. As discussed privately, this change is possibly, maybe even likely, benign, but touches a core component with a big blast radius, and reducibility issues are always hairy, so I cannot vouch for this change and the existing motivation (issue #12739) is not quite strong enough to take the risks or to spend more time thinking about it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures the
isNonTrivialProofcall inAbstracNestedProofs.visitruns with enough transparency to not trigger errors during its potentialinferTypecall. This is needed when abstracting over proofs that may be needed to reduce a structurally recursive function eliminating fromProptoType.In preparation for #12718.