Merged
Conversation
Member
Author
|
RFC |
Member
Author
|
t-space-time |
Member
Author
|
-RFC |
Member
Author
|
RFC |
zhikaip
reviewed
Mar 16, 2026
| open Manifold in | ||
| /-- The spatial-derivative in terms of the derivative of functions between | ||
| manifolds with the manifold structure `Space.manifoldStructure d`. | ||
| This should eventually be used as the definition of `deriv`. -/ |
Collaborator
There was a problem hiding this comment.
Maybe this should be a TODO?
zhikaip
previously approved these changes
Mar 16, 2026
Collaborator
zhikaip
left a comment
zhikaip
left a comment
There was a problem hiding this comment.
I'm not familiar with the API, but other than the comment (TODO item deriv refactor) looks good to me
Member
Author
|
@zhikaip Made this a TODO item. |
zhikaip
added
ready-to-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new formula for derivatives on space in terms of the origin-independent manifold structure on
Space. Added a number of other small lemmas needed along the way.