Fix PreExecuter pointer comparisons#366
Merged
Merged
Conversation
Member
|
@DutChen18 What about making the methods non-static as an alternative? The current solution is ok, but let's see if this would be better. |
Member
Author
|
@alexp-sssup Making them instance methods requires declaring them in the header, are you sure this is better? |
Member
|
No, then it would not be better. I misread static as "class static". It's just static methods though. |
Pointers needed to have their tags removed before the comparison
DutChen18
force-pushed
the
fix-preexecuter-pointer-compare
branch
from
df0ca25 to
62701e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pointers needed to have their tags removed before the comparison.
It's a bit ugly to have to pass around the interpreter instance everywhere, but this solution seemed better than the alternatives.