Skip to content

Fix to LCAbyg export algorithm#35

Closed
LasSteJen wants to merge 2 commits intostagefrom
fix-lcabyg-export
Closed

Fix to LCAbyg export algorithm#35
LasSteJen wants to merge 2 commits intostagefrom
fix-lcabyg-export

Conversation

@LasSteJen
Copy link

@LasSteJen LasSteJen commented Apr 30, 2024

Fixed LCAbyg exporter. Fix includes

  1. Comments now defaults to empty string if missing (LCAbyg does not allow null values)
  2. Stages now contain the type of stage in their name. E.g. A1.
  3. Conversions is now correctly exported as mass_factor. This should also fix possible future issues when we change casing of "kg".
  4. Lastly, layer nodes are now exported only once (before we created a new layer for each element). This allows a user to reuse same layer in LCAbyg rather than having multiple identical products (LCAbyg name)

An alternative solution to 4. would be to generate a new UUID for each layer. I think the current solution is the better one. Let me know what you think.

EDIT: This is a first step in solving this issue

* Layer nodes are now exported only once
* Comment property on exported nodes now defaults to empty string
* Conversion or mass_factor is now exported correctly
* Stages now contains the specific type of stage in its name
@LasSteJen LasSteJen requested a review from a team April 30, 2024 06:25
@LasSteJen
Copy link
Author

Closed because this PR reworks the exported and contains the same fixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant