Skip to content

generic clustering#33

Open
erik-romson wants to merge 14 commits into
lbehnke:masterfrom
erik-romson:master
Open

generic clustering#33
erik-romson wants to merge 14 commits into
lbehnke:masterfrom
erik-romson:master

Conversation

@erik-romson

Copy link
Copy Markdown

Hi
I found your library interesting but I needed to cluster based on objects, not strings. see src/test/java/com/apporiented/algorithm/clustering/ClusterPersonTest.java for an example.

So I rewrote it to handle generics and added some streaming as well (a few more dependencies but only in test scope).

I realize that this is a big change (code wise anyway), so I'll stop here. If you are interested to merge, let me know and I'll clean it up and do whatever you want me to fix

@lbehnke

lbehnke commented Dec 13, 2019

Copy link
Copy Markdown
Owner

Thanks for this contribution. It certainly makes sense to use generic cluster nodes and I'd like to merge it. So if you could resolve the merge conflicts and clean up the code that would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants