Conversation
DynamoDB returns numeric fields (createdAt, lastAccessTime) as Decimal objects, which the standard json.dumps cannot serialize. Swap to the existing json_dumps utility which uses DecimalEncoder to convert Decimals to floats.
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||
Diff for stage: DefaultStageDiff for stack: GitHubOidcStack - 0 to add, 1 to update, 0 to destroy 🟡DetailsResources
[~] Custom::AWSCDKOpenIdConnectProvider GitHubOidcProvider7EBF861F
├─ [~] CodeHash
│ ├─ [-] 62fa02efcaa700e1c247e1d3cc2aa0cd07a0808a9a3e3d2230e51f57a02233fb
│ └─ [+] d75c48c9f82cde63e9bf414df335e84e8ac24f11eb34889be255b702aec71e50
└─ [~] RejectUnauthorized
[~] AWS::Lambda::Function CustomAWSCDKOpenIdConnectProviderCustomResourceProviderHandlerF2C543E0
├─ [~] Code
│ └─ [~] .S3Key:
│ ├─ [-] 62fa02efcaa700e1c247e1d3cc2aa0cd07a0808a9a3e3d2230e51f57a02233fb.zip
│ └─ [+] d75c48c9f82cde63e9bf414df335e84e8ac24f11eb34889be255b702aec71e50.zip
└─ [~] Metadata
└─ [~] .aws:asset:path:
├─ [-] asset.62fa02efcaa700e1c247e1d3cc2aa0cd07a0808a9a3e3d2230e51f57a02233fb
└─ [+] asset.d75c48c9f82cde63e9bf414df335e84e8ac24f11eb34889be255b702aec71e50
Diff for stack: Service-prod - 0 to add, 0 to update, 0 to destroy ✅DetailsResources
[~] AWS::Lambda::Function AuthApiHandlerED50ACFA
├─ [~] Code
│ └─ [~] .S3Key:
│ ├─ [-] 6e7b68b5b107e56522cc306a58423e59ffdea3918ca8c745c847f831592141b7.zip
│ └─ [+] d5dda210abc5cad8d04de1baa1e4c3c74c22dfd51aef2a701cbb3664c3dd2c21.zip
└─ [~] Metadata
└─ [~] .aws:asset:path:
├─ [-] asset.6e7b68b5b107e56522cc306a58423e59ffdea3918ca8c745c847f831592141b7
└─ [+] asset.d5dda210abc5cad8d04de1baa1e4c3c74c22dfd51aef2a701cbb3664c3dd2c21
[~] AWS::Lambda::Function TokenApiHandler2E66DB25
├─ [~] Code
│ └─ [~] .S3Key:
│ ├─ [-] 6e7b68b5b107e56522cc306a58423e59ffdea3918ca8c745c847f831592141b7.zip
│ └─ [+] d5dda210abc5cad8d04de1baa1e4c3c74c22dfd51aef2a701cbb3664c3dd2c21.zip
└─ [~] Metadata
└─ [~] .aws:asset:path:
├─ [-] asset.6e7b68b5b107e56522cc306a58423e59ffdea3918ca8c745c847f831592141b7
└─ [+] asset.d5dda210abc5cad8d04de1baa1e4c3c74c22dfd51aef2a701cbb3664c3dd2c21
[~] AWS::Lambda::Function ProfileApiHandler9B65A298
├─ [~] Code
│ └─ [~] .S3Key:
│ ├─ [-] 6e7b68b5b107e56522cc306a58423e59ffdea3918ca8c745c847f831592141b7.zip
│ └─ [+] d5dda210abc5cad8d04de1baa1e4c3c74c22dfd51aef2a701cbb3664c3dd2c21.zip
└─ [~] Metadata
└─ [~] .aws:asset:path:
├─ [-] asset.6e7b68b5b107e56522cc306a58423e59ffdea3918ca8c745c847f831592141b7
└─ [+] asset.d5dda210abc5cad8d04de1baa1e4c3c74c22dfd51aef2a701cbb3664c3dd2c21
[~] AWS::Lambda::Function ApiHandler5E7490E8
├─ [~] Code
│ └─ [~] .S3Key:
│ ├─ [-] 6e7b68b5b107e56522cc306a58423e59ffdea3918ca8c745c847f831592141b7.zip
│ └─ [+] d5dda210abc5cad8d04de1baa1e4c3c74c22dfd51aef2a701cbb3664c3dd2c21.zip
└─ [~] Metadata
└─ [~] .aws:asset:path:
├─ [-] asset.6e7b68b5b107e56522cc306a58423e59ffdea3918ca8c745c847f831592141b7
└─ [+] asset.d5dda210abc5cad8d04de1baa1e4c3c74c22dfd51aef2a701cbb3664c3dd2c21
[~] AWS::Lambda::Function ChannelApiHandler02759D57
├─ [~] Code
│ └─ [~] .S3Key:
│ ├─ [-] 95e5fb7e938ee8469f2d4ae8d4257ceb5aec48be1b04194dcb20388b05e968f1.zip
│ └─ [+] 36bc2aabcf396fa8cb5642aea04457f0ab6d238f94b2608c8da56d03044b4b0b.zip
└─ [~] Metadata
└─ [~] .aws:asset:path:
├─ [-] asset.95e5fb7e938ee8469f2d4ae8d4257ceb5aec48be1b04194dcb20388b05e968f1
└─ [+] asset.36bc2aabcf396fa8cb5642aea04457f0ab6d238f94b2608c8da56d03044b4b0b
No Changes for stack: Frontend-prod ✅ Generated for commit 557f269 at 2026-03-04T03:07:04.898Z |
Same Decimal serialization issue as account_attached_clients: both routes serialize DynamoDB data that may contain Decimal values for createdAt and lastAccessTime fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createdAt,lastAccessTime) asDecimalobjects, causingTypeError: Object of type Decimal is not JSON serializablein device-related endpointsjson.dumpswith the existingjson_dumpsutility (src/shared/utils.py) which usesDecimalEncoderto convertDecimal→floatGET /v1/account/attached_clientsGET /v1/account/devicesPOST /v1/account/deviceTest plan
TypeErrorfor users with devices that have numeric timestamp fields