feat: add device endpoints to Smithy model#271
Merged
Conversation
Add Device resource to AuthService with 4 operations: - POST /v1/account/device (RegisterDevice) - GET /v1/account/devices (ListDevices) - GET /v1/account/attached_clients (ListAttachedClients) - POST /v1/account/devices/notify (NotifyDevices) Without these routes in the API Gateway OpenAPI spec, requests return 403 before the Lambda is invoked.
Diff for stage: DefaultStageWarning 3 Destructive Changes Diff for stack: GitHubOidcStack - 0 to add, 1 to update, 0 to destroy 🟡DetailsResources
[~] Custom::AWSCDKOpenIdConnectProvider GitHubOidcProvider7EBF861F
├─ [~] CodeHash
│ ├─ [-] 62fa02efcaa700e1c247e1d3cc2aa0cd07a0808a9a3e3d2230e51f57a02233fb
│ └─ [+] d75c48c9f82cde63e9bf414df335e84e8ac24f11eb34889be255b702aec71e50
└─ [~] RejectUnauthorized
[~] AWS::Lambda::Function CustomAWSCDKOpenIdConnectProviderCustomResourceProviderHandlerF2C543E0
├─ [~] Code
│ └─ [~] .S3Key:
│ ├─ [-] 62fa02efcaa700e1c247e1d3cc2aa0cd07a0808a9a3e3d2230e51f57a02233fb.zip
│ └─ [+] d75c48c9f82cde63e9bf414df335e84e8ac24f11eb34889be255b702aec71e50.zip
└─ [~] Metadata
└─ [~] .aws:asset:path:
├─ [-] asset.62fa02efcaa700e1c247e1d3cc2aa0cd07a0808a9a3e3d2230e51f57a02233fb
└─ [+] asset.d75c48c9f82cde63e9bf414df335e84e8ac24f11eb34889be255b702aec71e50
Diff for stack: Service-prod - 3 to add, 4 to update, 3 to destroy ❌Details
Resources
[-] AWS::ApiGateway::Deployment AuthApiDeploymentB62B2E4627f0b326f37b837e2a54a9393870f6be destroy
[-] AWS::ApiGateway::Deployment TokenApiDeploymentB896C2197f4fd8f40928d8ff6b65325e6f60c797 destroy
[-] AWS::ApiGateway::Deployment ProfileApiDeployment84A54415afa95090416ea0bbd4b1d2aac5a9241c destroy
[+] AWS::ApiGateway::Deployment AuthApiDeploymentB62B2E46e6df84b588a887363a13ab29adc3623c
[+] AWS::ApiGateway::Deployment TokenApiDeploymentB896C219b16a73c2bacf13dff150a851137e236c
[+] AWS::ApiGateway::Deployment ProfileApiDeployment84A54415e0158c62574d24c31b8dbd21e82873c4
[~] AWS::ApiGateway::RestApi AuthApi4BD72F20
└─ [~] Body
├─ [~] .components:
│ └─ [~] .schemas:
│ ├─ [+] Added: .AttachedClient
│ ├─ [+] Added: .AvailableCommandsMap
│ ├─ [+] Added: .DeviceRecord
│ ├─ [+] Added: .ListAttachedClientsResponseContent
│ ├─ [+] Added: .ListDevicesResponseContent
│ ├─ [+] Added: .RegisterDeviceRequestContent
│ └─ [+] Added: .RegisterDeviceResponseContent
└─ [~] .paths:
├─ [+] Added: ./v1/account/attached_clients
├─ [+] Added: ./v1/account/device
├─ [+] Added: ./v1/account/devices
└─ [+] Added: ./v1/account/devices/notify
[~] AWS::ApiGateway::Stage AuthApiDeploymentStageprodB0E4172A
└─ [~] DeploymentId
└─ [~] .Ref:
├─ [-] AuthApiDeploymentB62B2E4627f0b326f37b837e2a54a9393870f6be
└─ [+] AuthApiDeploymentB62B2E46e6df84b588a887363a13ab29adc3623c
[~] AWS::ApiGateway::Stage TokenApiDeploymentStageprod11035AE4
└─ [~] DeploymentId
└─ [~] .Ref:
├─ [-] TokenApiDeploymentB896C2197f4fd8f40928d8ff6b65325e6f60c797
└─ [+] TokenApiDeploymentB896C219b16a73c2bacf13dff150a851137e236c
[~] AWS::ApiGateway::Stage ProfileApiDeploymentStageprodF609D968
└─ [~] DeploymentId
└─ [~] .Ref:
├─ [-] ProfileApiDeployment84A54415afa95090416ea0bbd4b1d2aac5a9241c
└─ [+] ProfileApiDeployment84A54415e0158c62574d24c31b8dbd21e82873c4
No Changes for stack: Frontend-prod ✅ Generated for commit 3dedc03 at 2026-03-03T05:01:07.987Z |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the 4 device management endpoints to the Smithy model so API Gateway generates routes for them.
Context
PR #269 added the Lambda route handlers for device endpoints, but they still return 403 because the routes don't exist in the API Gateway OpenAPI spec. The auth API uses
SpecRestApiwith a Smithy-generated OpenAPI spec — without the routes defined in Smithy, API Gateway rejects requests before the Lambda is invoked.Changes
smithy/models/auth/device.smithy— Device resource with 4 operationssmithy/models/main.smithy— AddDeviceto AuthService resourcesTest plan
smithyBuildsucceeds (804 shapes validated)