Skip to content

fix: use lowercase channelid in WebSocket response#270

Merged
layertwo merged 1 commit intomainlinefrom
fix/channel-id-casing
Mar 3, 2026
Merged

fix: use lowercase channelid in WebSocket response#270
layertwo merged 1 commit intomainlinefrom
fix/channel-id-casing

Conversation

@layertwo
Copy link
Owner

@layertwo layertwo commented Mar 3, 2026

Summary

  • Fix PairingChannel.create() hanging indefinitely by using lowercase channelid in the WebSocket response, matching the Mozilla channelserver protocol
  • The fxa-pairing-channel library destructures { channelid: channelId } (lowercase key), but we were sending {"channelId": ...} (camelCase), resulting in undefined
  • Add structured logging to all channel service operations

Test plan

  • 975 Python tests pass (1 pre-existing unrelated flaky test)
  • Deploy and verify /pair page creates channel and shows QR code

The fxa-pairing-channel library expects lowercase "channelid" in the
initial WebSocket message (matching Mozilla's channelserver protocol),
but we were sending "channelId" (camelCase). This caused PairingChannel
.create() to hang indefinitely because the channel ID was undefined.

Also adds structured logging to all channel service operations.
@github-actions
Copy link

github-actions bot commented Mar 3, 2026

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  lambda/src/services
  channel_service.py
Project Total  

This report was generated by python-coverage-comment-action

@github-actions
Copy link

github-actions bot commented Mar 3, 2026

Diff for stage: DefaultStage

Warning

3 Destructive Changes

Diff for stack: GitHubOidcStack - 0 to add, 1 to update, 0 to destroy 🟡

Details
Resources
[~] Custom::AWSCDKOpenIdConnectProvider GitHubOidcProvider7EBF861F
 ├─ [~] CodeHash
 │   ├─ [-] 62fa02efcaa700e1c247e1d3cc2aa0cd07a0808a9a3e3d2230e51f57a02233fb
 │   └─ [+] d75c48c9f82cde63e9bf414df335e84e8ac24f11eb34889be255b702aec71e50
 └─ [~] RejectUnauthorized
[~] AWS::Lambda::Function CustomAWSCDKOpenIdConnectProviderCustomResourceProviderHandlerF2C543E0
 ├─ [~] Code
 │   └─ [~] .S3Key:
 │       ├─ [-] 62fa02efcaa700e1c247e1d3cc2aa0cd07a0808a9a3e3d2230e51f57a02233fb.zip
 │       └─ [+] d75c48c9f82cde63e9bf414df335e84e8ac24f11eb34889be255b702aec71e50.zip
 └─ [~] Metadata
     └─ [~] .aws:asset:path:
         ├─ [-] asset.62fa02efcaa700e1c247e1d3cc2aa0cd07a0808a9a3e3d2230e51f57a02233fb
         └─ [+] asset.d75c48c9f82cde63e9bf414df335e84e8ac24f11eb34889be255b702aec71e50

Diff for stack: Service-prod - 3 to add, 3 to update, 3 to destroy

Details

[!WARNING]
Destructive Changes ‼️
Stack: Service-prod - Resource: AuthApiDeploymentB62B2E4627f0b326f37b837e2a54a9393870f6be - Impact: WILL_DESTROY

Stack: Service-prod - Resource: TokenApiDeploymentB896C2197f4fd8f40928d8ff6b65325e6f60c797 - Impact: WILL_DESTROY

Stack: Service-prod - Resource: ProfileApiDeployment84A54415afa95090416ea0bbd4b1d2aac5a9241c - Impact: WILL_DESTROY

Resources
[-] AWS::ApiGateway::Deployment AuthApiDeploymentB62B2E4627f0b326f37b837e2a54a9393870f6be destroy
[-] AWS::ApiGateway::Deployment TokenApiDeploymentB896C2197f4fd8f40928d8ff6b65325e6f60c797 destroy
[-] AWS::ApiGateway::Deployment ProfileApiDeployment84A54415afa95090416ea0bbd4b1d2aac5a9241c destroy
[+] AWS::ApiGateway::Deployment AuthApiDeploymentB62B2E46cd727903b39a54701810720fe0a5fca4
[+] AWS::ApiGateway::Deployment TokenApiDeploymentB896C219b16a73c2bacf13dff150a851137e236c
[+] AWS::ApiGateway::Deployment ProfileApiDeployment84A54415e0158c62574d24c31b8dbd21e82873c4
[~] AWS::Lambda::Function AuthApiHandlerED50ACFA
 ├─ [~] Code
 │   └─ [~] .S3Key:
 │       ├─ [-] 5174e8eb39d2a8923c1463ac8268cc0ba8191e0dbc87557af1d142a35d5b5988.zip
 │       └─ [+] e6eebee4054066b6d57bda3a38c7eb0c734974384816b8ecd06b523b3d67895c.zip
 └─ [~] Metadata
     └─ [~] .aws:asset:path:
         ├─ [-] asset.5174e8eb39d2a8923c1463ac8268cc0ba8191e0dbc87557af1d142a35d5b5988
         └─ [+] asset.e6eebee4054066b6d57bda3a38c7eb0c734974384816b8ecd06b523b3d67895c
[~] AWS::Lambda::Function TokenApiHandler2E66DB25
 ├─ [~] Code
 │   └─ [~] .S3Key:
 │       ├─ [-] 5174e8eb39d2a8923c1463ac8268cc0ba8191e0dbc87557af1d142a35d5b5988.zip
 │       └─ [+] e6eebee4054066b6d57bda3a38c7eb0c734974384816b8ecd06b523b3d67895c.zip
 └─ [~] Metadata
     └─ [~] .aws:asset:path:
         ├─ [-] asset.5174e8eb39d2a8923c1463ac8268cc0ba8191e0dbc87557af1d142a35d5b5988
         └─ [+] asset.e6eebee4054066b6d57bda3a38c7eb0c734974384816b8ecd06b523b3d67895c
[~] AWS::Lambda::Function ProfileApiHandler9B65A298
 ├─ [~] Code
 │   └─ [~] .S3Key:
 │       ├─ [-] 5174e8eb39d2a8923c1463ac8268cc0ba8191e0dbc87557af1d142a35d5b5988.zip
 │       └─ [+] e6eebee4054066b6d57bda3a38c7eb0c734974384816b8ecd06b523b3d67895c.zip
 └─ [~] Metadata
     └─ [~] .aws:asset:path:
         ├─ [-] asset.5174e8eb39d2a8923c1463ac8268cc0ba8191e0dbc87557af1d142a35d5b5988
         └─ [+] asset.e6eebee4054066b6d57bda3a38c7eb0c734974384816b8ecd06b523b3d67895c
[~] AWS::Lambda::Function ApiHandler5E7490E8
 ├─ [~] Code
 │   └─ [~] .S3Key:
 │       ├─ [-] 5174e8eb39d2a8923c1463ac8268cc0ba8191e0dbc87557af1d142a35d5b5988.zip
 │       └─ [+] e6eebee4054066b6d57bda3a38c7eb0c734974384816b8ecd06b523b3d67895c.zip
 └─ [~] Metadata
     └─ [~] .aws:asset:path:
         ├─ [-] asset.5174e8eb39d2a8923c1463ac8268cc0ba8191e0dbc87557af1d142a35d5b5988
         └─ [+] asset.e6eebee4054066b6d57bda3a38c7eb0c734974384816b8ecd06b523b3d67895c
[~] AWS::ApiGateway::Stage AuthApiDeploymentStageprodB0E4172A
 └─ [~] DeploymentId
     └─ [~] .Ref:
         ├─ [-] AuthApiDeploymentB62B2E4627f0b326f37b837e2a54a9393870f6be
         └─ [+] AuthApiDeploymentB62B2E46cd727903b39a54701810720fe0a5fca4
[~] AWS::ApiGateway::Stage TokenApiDeploymentStageprod11035AE4
 └─ [~] DeploymentId
     └─ [~] .Ref:
         ├─ [-] TokenApiDeploymentB896C2197f4fd8f40928d8ff6b65325e6f60c797
         └─ [+] TokenApiDeploymentB896C219b16a73c2bacf13dff150a851137e236c
[~] AWS::ApiGateway::Stage ProfileApiDeploymentStageprodF609D968
 └─ [~] DeploymentId
     └─ [~] .Ref:
         ├─ [-] ProfileApiDeployment84A54415afa95090416ea0bbd4b1d2aac5a9241c
         └─ [+] ProfileApiDeployment84A54415e0158c62574d24c31b8dbd21e82873c4
[~] AWS::Lambda::Function ChannelApiHandler02759D57
 ├─ [~] Code
 │   └─ [~] .S3Key:
 │       ├─ [-] 0823488cf4518e58ff22331aa868f9110776de70f7cba2b156f42954b11061e8.zip
 │       └─ [+] 1a72e657b8684e4911cda6c47b2b926974c2fc5bbb5642c69f660fd34ff5cdd8.zip
 └─ [~] Metadata
     └─ [~] .aws:asset:path:
         ├─ [-] asset.0823488cf4518e58ff22331aa868f9110776de70f7cba2b156f42954b11061e8
         └─ [+] asset.1a72e657b8684e4911cda6c47b2b926974c2fc5bbb5642c69f660fd34ff5cdd8

No Changes for stack: Frontend-prod ✅
No Changes for stack: Monitoring-prod ✅

Generated for commit ff3b334 at 2026-03-03T04:01:23.718Z

@layertwo layertwo merged commit 71c7154 into mainline Mar 3, 2026
10 checks passed
@layertwo layertwo deleted the fix/channel-id-casing branch March 5, 2026 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant