fix: use lowercase channelid in WebSocket response#270
Merged
Conversation
The fxa-pairing-channel library expects lowercase "channelid" in the initial WebSocket message (matching Mozilla's channelserver protocol), but we were sending "channelId" (camelCase). This caused PairingChannel .create() to hang indefinitely because the channel ID was undefined. Also adds structured logging to all channel service operations.
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Diff for stage: DefaultStageWarning 3 Destructive Changes Diff for stack: GitHubOidcStack - 0 to add, 1 to update, 0 to destroy 🟡DetailsResources
[~] Custom::AWSCDKOpenIdConnectProvider GitHubOidcProvider7EBF861F
├─ [~] CodeHash
│ ├─ [-] 62fa02efcaa700e1c247e1d3cc2aa0cd07a0808a9a3e3d2230e51f57a02233fb
│ └─ [+] d75c48c9f82cde63e9bf414df335e84e8ac24f11eb34889be255b702aec71e50
└─ [~] RejectUnauthorized
[~] AWS::Lambda::Function CustomAWSCDKOpenIdConnectProviderCustomResourceProviderHandlerF2C543E0
├─ [~] Code
│ └─ [~] .S3Key:
│ ├─ [-] 62fa02efcaa700e1c247e1d3cc2aa0cd07a0808a9a3e3d2230e51f57a02233fb.zip
│ └─ [+] d75c48c9f82cde63e9bf414df335e84e8ac24f11eb34889be255b702aec71e50.zip
└─ [~] Metadata
└─ [~] .aws:asset:path:
├─ [-] asset.62fa02efcaa700e1c247e1d3cc2aa0cd07a0808a9a3e3d2230e51f57a02233fb
└─ [+] asset.d75c48c9f82cde63e9bf414df335e84e8ac24f11eb34889be255b702aec71e50
Diff for stack: Service-prod - 3 to add, 3 to update, 3 to destroy ❌Details
Resources
[-] AWS::ApiGateway::Deployment AuthApiDeploymentB62B2E4627f0b326f37b837e2a54a9393870f6be destroy
[-] AWS::ApiGateway::Deployment TokenApiDeploymentB896C2197f4fd8f40928d8ff6b65325e6f60c797 destroy
[-] AWS::ApiGateway::Deployment ProfileApiDeployment84A54415afa95090416ea0bbd4b1d2aac5a9241c destroy
[+] AWS::ApiGateway::Deployment AuthApiDeploymentB62B2E46cd727903b39a54701810720fe0a5fca4
[+] AWS::ApiGateway::Deployment TokenApiDeploymentB896C219b16a73c2bacf13dff150a851137e236c
[+] AWS::ApiGateway::Deployment ProfileApiDeployment84A54415e0158c62574d24c31b8dbd21e82873c4
[~] AWS::Lambda::Function AuthApiHandlerED50ACFA
├─ [~] Code
│ └─ [~] .S3Key:
│ ├─ [-] 5174e8eb39d2a8923c1463ac8268cc0ba8191e0dbc87557af1d142a35d5b5988.zip
│ └─ [+] e6eebee4054066b6d57bda3a38c7eb0c734974384816b8ecd06b523b3d67895c.zip
└─ [~] Metadata
└─ [~] .aws:asset:path:
├─ [-] asset.5174e8eb39d2a8923c1463ac8268cc0ba8191e0dbc87557af1d142a35d5b5988
└─ [+] asset.e6eebee4054066b6d57bda3a38c7eb0c734974384816b8ecd06b523b3d67895c
[~] AWS::Lambda::Function TokenApiHandler2E66DB25
├─ [~] Code
│ └─ [~] .S3Key:
│ ├─ [-] 5174e8eb39d2a8923c1463ac8268cc0ba8191e0dbc87557af1d142a35d5b5988.zip
│ └─ [+] e6eebee4054066b6d57bda3a38c7eb0c734974384816b8ecd06b523b3d67895c.zip
└─ [~] Metadata
└─ [~] .aws:asset:path:
├─ [-] asset.5174e8eb39d2a8923c1463ac8268cc0ba8191e0dbc87557af1d142a35d5b5988
└─ [+] asset.e6eebee4054066b6d57bda3a38c7eb0c734974384816b8ecd06b523b3d67895c
[~] AWS::Lambda::Function ProfileApiHandler9B65A298
├─ [~] Code
│ └─ [~] .S3Key:
│ ├─ [-] 5174e8eb39d2a8923c1463ac8268cc0ba8191e0dbc87557af1d142a35d5b5988.zip
│ └─ [+] e6eebee4054066b6d57bda3a38c7eb0c734974384816b8ecd06b523b3d67895c.zip
└─ [~] Metadata
└─ [~] .aws:asset:path:
├─ [-] asset.5174e8eb39d2a8923c1463ac8268cc0ba8191e0dbc87557af1d142a35d5b5988
└─ [+] asset.e6eebee4054066b6d57bda3a38c7eb0c734974384816b8ecd06b523b3d67895c
[~] AWS::Lambda::Function ApiHandler5E7490E8
├─ [~] Code
│ └─ [~] .S3Key:
│ ├─ [-] 5174e8eb39d2a8923c1463ac8268cc0ba8191e0dbc87557af1d142a35d5b5988.zip
│ └─ [+] e6eebee4054066b6d57bda3a38c7eb0c734974384816b8ecd06b523b3d67895c.zip
└─ [~] Metadata
└─ [~] .aws:asset:path:
├─ [-] asset.5174e8eb39d2a8923c1463ac8268cc0ba8191e0dbc87557af1d142a35d5b5988
└─ [+] asset.e6eebee4054066b6d57bda3a38c7eb0c734974384816b8ecd06b523b3d67895c
[~] AWS::ApiGateway::Stage AuthApiDeploymentStageprodB0E4172A
└─ [~] DeploymentId
└─ [~] .Ref:
├─ [-] AuthApiDeploymentB62B2E4627f0b326f37b837e2a54a9393870f6be
└─ [+] AuthApiDeploymentB62B2E46cd727903b39a54701810720fe0a5fca4
[~] AWS::ApiGateway::Stage TokenApiDeploymentStageprod11035AE4
└─ [~] DeploymentId
└─ [~] .Ref:
├─ [-] TokenApiDeploymentB896C2197f4fd8f40928d8ff6b65325e6f60c797
└─ [+] TokenApiDeploymentB896C219b16a73c2bacf13dff150a851137e236c
[~] AWS::ApiGateway::Stage ProfileApiDeploymentStageprodF609D968
└─ [~] DeploymentId
└─ [~] .Ref:
├─ [-] ProfileApiDeployment84A54415afa95090416ea0bbd4b1d2aac5a9241c
└─ [+] ProfileApiDeployment84A54415e0158c62574d24c31b8dbd21e82873c4
[~] AWS::Lambda::Function ChannelApiHandler02759D57
├─ [~] Code
│ └─ [~] .S3Key:
│ ├─ [-] 0823488cf4518e58ff22331aa868f9110776de70f7cba2b156f42954b11061e8.zip
│ └─ [+] 1a72e657b8684e4911cda6c47b2b926974c2fc5bbb5642c69f660fd34ff5cdd8.zip
└─ [~] Metadata
└─ [~] .aws:asset:path:
├─ [-] asset.0823488cf4518e58ff22331aa868f9110776de70f7cba2b156f42954b11061e8
└─ [+] asset.1a72e657b8684e4911cda6c47b2b926974c2fc5bbb5642c69f660fd34ff5cdd8
No Changes for stack: Frontend-prod ✅ Generated for commit ff3b334 at 2026-03-03T04:01:23.718Z |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PairingChannel.create()hanging indefinitely by using lowercasechannelidin the WebSocket response, matching the Mozilla channelserver protocol{ channelid: channelId }(lowercase key), but we were sending{"channelId": ...}(camelCase), resulting inundefinedTest plan