feat: uniform UI margins and theme-aware warning brushes#618
feat: uniform UI margins and theme-aware warning brushes#618laurentiu021 wants to merge 1 commit into
Conversation
- 13 views migrated from Margin="32,24" to canonical "28,24,28,16" (BatteryHealth, BulkInstaller, ContextMenu, DiskAnalyzer, Drivers, DuplicateFile, Performance, Privacy, ProcessManager, Services, Startup, Uninstaller, WindowsFeatures)
- 15 views: drop hardcoded LinearGradientBrush PageBg, use {DynamicResource Surface0} on root Grid (removes 5 lines per file, theme-aware)
- 17 views: replace hardcoded amber hex (#1AFBBF24, #40FBBF24, #FBBF24, #FCD34D) with new App.xaml theme brushes WarningBgSubtle, WarningBg, WarningStripe, WarningText
|
Warning Review limit reached
More reviews will be available in 41 minutes and 24 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (33)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Summary
Round 4 of the post-1.18.0 audit fixes — UI uniformity sweep. Three categories of visual inconsistency consolidated, all decisions confirmed by user.
What changed
1. Outer container margins —
28,24,28,16everywhere13 views were using
Margin="32,24"while Dashboard and AppAlerts used the documented standard28,24,28,16. Migrated all to the standard:BatteryHealth, BulkInstaller, ContextMenu, DiskAnalyzer, Drivers, DuplicateFile, Performance, Privacy, ProcessManager, Services, Startup, Uninstaller, WindowsFeatures.
The whole nav now has identical horizontal padding when switching tabs.
2. Page background — theme-aware
15 views were each defining a per-file
LinearGradientBrush x:Key="PageBg"resource (3 hardcoded hex stops:#070A0F/#0B1220/#090D16) and then settingGrid.Background="{StaticResource PageBg}". Net effect: ~75 hardcoded color references that broke theme switching.Replaced everywhere with
Background="{DynamicResource Surface0}"(the theme-managed root surface brush, identical visual color in dark mode). The local<UserControl.Resources><LinearGradientBrush>blocks are gone; non-PageBg resources (e.g., FileShredderView's ObjectDataProvider, LogsView's local styles) are preserved.3. Warning category brushes — defined once, reused
The admin elevation banner (and a few warning pills) duplicated 4 amber hex values across 17 views:
#1AFBBF24,#40FBBF24,#FBBF24,#FCD34D. Defined them once inApp.xaml:Replaced all 4 hex literals across 17 views with
{DynamicResource ...}. Future tweaks to the warning palette are now a one-line change in App.xaml.Not in this PR
Views/AdminBanner.xamlUserControl withDependencyPropertyfor the message text is a non-trivial refactor with its own design risk; left for a focused follow-up.Files
33 files changed, 103 insertions, 193 deletions (net cleanup):
App.xaml— 4 new Warning* brushesCHANGELOG.md—[1.19.0]entrySysManager.csproj— bump to 1.19.0 (user-visible UI change → minor bump)Test plan
dotnet buildRelease: 0 warnings, 0 errors (main project)