Skip to content

fix: remaining audit findings — performance and visual consistency#603

Merged
laurentiu021 merged 1 commit into
mainfrom
fix/audit-low-priority
May 29, 2026
Merged

fix: remaining audit findings — performance and visual consistency#603
laurentiu021 merged 1 commit into
mainfrom
fix/audit-low-priority

Conversation

@laurentiu021
Copy link
Copy Markdown
Owner

Summary

Final batch of audit findings (Low priority):

  • NetworkSharedStateTracerouteHops converted from ObservableCollection to BulkObservableCollection with ReplaceWith(). Eliminates per-hop UI change notifications during route refreshes.
  • ServicesViewModel — safety level counts (Safe/Caution/Critical) now computed in a single foreach pass instead of 3 separate LINQ .Count() queries over 200+ items.
  • DnsHostsView — removed stale HorizontalGridLinesBrush="#1E293B" property (no visual effect since GridLinesVisibility="None").
  • AppBlockerView — DataGrid BorderThickness set to 0, matching all other DataGrids in the app.
  • ConsoleViewModel RemoveAt(0) — left as-is (O(1) in practice with MaxLines trim of 1 item; no WPF-bindable deque alternative).

Test plan

  • Traceroute tab: route updates display correctly without flicker
  • Services tab: filter works, safety counts correct
  • DNS & Hosts tab: table displays correctly (no border artifacts)
  • App Blocker tab: DataGrid blends with dark background

- NetworkSharedState: TracerouteHops → BulkObservableCollection.ReplaceWith()
- ServicesViewModel: single-pass safety level count (was 3 LINQ passes)
- DnsHostsView: remove stale HorizontalGridLinesBrush property
- AppBlockerView: DataGrid BorderThickness=0 (consistency)
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 29, 2026

Warning

Review limit reached

@laurentiu021, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 23 minutes and 53 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d7a3c94d-6399-46cb-8a7a-408dcf93825c

📥 Commits

Reviewing files that changed from the base of the PR and between 760dd23 and 21b2e74.

📒 Files selected for processing (6)
  • CHANGELOG.md
  • SysManager/SysManager/SysManager.csproj
  • SysManager/SysManager/ViewModels/NetworkSharedState.cs
  • SysManager/SysManager/ViewModels/ServicesViewModel.cs
  • SysManager/SysManager/Views/AppBlockerView.xaml
  • SysManager/SysManager/Views/DnsHostsView.xaml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/audit-low-priority

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@laurentiu021 laurentiu021 merged commit e7c32d2 into main May 29, 2026
4 of 5 checks passed
@laurentiu021 laurentiu021 deleted the fix/audit-low-priority branch May 29, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant