fix: restore ES2017 lib in tsconfig.base.json#34
Merged
Conversation
The upstream refresh took upstream's "lib": ["es6", "dom"], which only compiles by accident in this repo: vitest's type declarations pull in modern ES lib references, masking uses of Array.prototype.includes and Object.entries. Inside the observability-sdk workspace the type layout differs and tsc fails with TS2550. Restore the fork's ES2017 lib, which matches the APIs the source actually uses. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ntiner1
approved these changes
Jun 11, 2026
Vadman97
added a commit
to launchdarkly/observability-sdk
that referenced
this pull request
Jun 11, 2026
## Summary Bumps the `rrweb` submodule to current fork main, which includes: - **Upstream refresh to rrweb v2.0.1** (launchdarkly/rrweb#29) — first upstream sync in ~2 years, plus standalone CI (build/lint/tests) for the fork - **Dependabot updates** (launchdarkly/rrweb#31) — vite 6, vitest 3, happy-dom 20, turbo 2.9 - **tsconfig lib fix** (launchdarkly/rrweb#34) — restores ES2017 lib so `@highlight-run/rrweb` type-checks inside this workspace Only the submodule pin and the regenerated `yarn.lock` change — no SDK source changes needed (main already migrated to vite 6 / vitest 4, which covers the previously-required companion changes). ## Validation (local, against this exact pin) - `yarn install` + `yarn dedupe --check` clean - `yarn build:sdk` 18/18 tasks green - `yarn enforce-size` 9/9 (highlight.run within the 256 kB brotli limit) - `yarn turbo run test --filter=highlight.run` — 437/437 tests pass ## Release `feat:` commit → release-please cuts a **minor** for `highlight.run`; the `node-workspace` plugin cascades linked bumps to `@launchdarkly/observability` and `@launchdarkly/session-replay`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **High Risk** > Large session-replay dependency refresh after a long upstream gap; replay fidelity and bundle behavior depend on rrweb even though SDK code is unchanged in this PR. > > **Overview** > Updates the vendored **launchdarkly/rrweb** workspace (submodule refresh to upstream **v2.0.1**) and regenerates **`yarn.lock`** so Highlight’s session-replay stack matches the fork’s current packages and tooling. > > The lockfile shifts rrweb workspaces toward **Vite 6**, **Vitest 3**, **happy-dom 20**, **Playwright 1.60**, and **turbo 2.9**, and wires in new fork packages such as **`@highlight-run/rrweb-browser-client`** and the **network record/replay** plugins. **`sdk/highlight-run/README.md`** now states that recording uses the LaunchDarkly rrweb fork synced to v2.0.1. > > No `highlight.run` SDK source changes in this diff—only dependency/workspace metadata and documentation. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 16df13f. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upstream refresh (#29) took upstream's
"lib": ["es6", "dom"]intsconfig.base.json. That setting only compiles by accident in this repo standalone: vitest's type declarations pull in modern ES lib references, masking the source's uses ofArray.prototype.includes(ES2016) andObject.entries(ES2017). Inside the observability-sdk workspace the type layout differs and@highlight-run/rrweb'stsc -noEmitfails with TS2550 errors, breaking o11y'sbuild:sdk.Restores the fork's previous
ES2017lib, which matches the APIs the source actually uses.libonly affects type-checking — emitted output is governed bytarget/vite config, so no runtime change.Validated: standalone
tsc -noEmitgreen for rrweb + rrweb-snapshot; observability-sdkbuild:sdkgoes 9/11 failed → 18/18 green with this change.🤖 Generated with Claude Code