fix: add release-please version markers to csproj#21
Open
kinyoklion wants to merge 1 commit into
Open
Conversation
The .csproj Version tag was not managed by release-please because: 1. The file was missing from extra-files in release-please-config.json 2. The Version tag lacked x-release-please-start-version/end markers Without this, the NuGet package would be built with the old version on every release, causing the publish to fail since that version already exists on NuGet. Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release-please doesn't update the
<Version>in the.csprojbecause the file is missing fromextra-filesand lacksx-release-please-start-version/x-release-please-endmarkers. This means the NuGet package would be built with the old version on every release, anddotnet nuget pushwould fail since that version already exists on NuGet.Adds the csproj to
extra-filesinrelease-please-config.jsonand wraps the<Version>tag with release-please markers — matching how the NLog and MS logging adapters are configured.Link to Devin session: https://app.devin.ai/sessions/746778111964463bbcfa2ddded90cb85
Requested by: @kinyoklion
Note
Low Risk
Release automation and project metadata only; no runtime or API behavior changes.
Overview
Fixes release-please so the NuGet package version bumps on each release.
release-please-config.jsonnow listssrc/LaunchDarkly.Logging/LaunchDarkly.Logging.csprojunderextra-files, and the csproj wraps<Version>withx-release-please-start-version/x-release-please-endmarkers (same pattern asPROVENANCE.md). Without this, releases could keep building and pushing2.0.0, causingdotnet nuget pushfailures.Reviewed by Cursor Bugbot for commit 4f73aba. Bugbot is set up for automated code reviews on this repo. Configure here.