Dev of analysis helpers#2
Open
kdaily wants to merge 2 commits into
Open
Conversation
added 2 commits
November 7, 2014 11:40
Updated query2df to better handle list types.
Owner
There was a problem hiding this comment.
There are actually way more types than this (most of them depricated):
{0:'dataset',1: 'layer',2: 'project',3: 'preview',4: 'folder',5: 'analysis',6: 'step',
7: 'code',8: 'link',9: 'phenotypedata',10:'genotypedata',11:'expressiondata',12:'robject',
13:'summary',14:'genomicdata',15:'page',16:'file',17:'table',18:'community'}
Since the return type is always type.annotation I have in other places moved to doing:
new_key = '.'.join(key.split('.')[1:])
which I think should work generically.
Author
There was a problem hiding this comment.
Oh! Didn't realize all those types. I agree with your suggestion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry for the massive amount of changes; probably breaks some things so I can undo and handle them separately. You might want to pull this branch separately and test.
Added logging instead of print lines.
Removed global synapse login; each function should take a synapseclient.Synapse object (more flexibility)
Rewrote the query2df to handle different table types (entity, file, etc). Also, added option if passing a delimiter, merges values in a column instead of taking the first one.