[0.x] Fix PrismTool dropping arguments when provider uses 'input' key#355
Open
sumaiazaman wants to merge 1 commit intolaravel:0.xfrom
Open
[0.x] Fix PrismTool dropping arguments when provider uses 'input' key#355sumaiazaman wants to merge 1 commit intolaravel:0.xfrom
sumaiazaman wants to merge 1 commit intolaravel:0.xfrom
Conversation
Some providers send tool call arguments under the 'input' key instead of 'arguments'. PrismTool::toLaravelToolCall() and toLaravelToolResult() only check for 'arguments', silently dropping all arguments when 'input' is used. Fixes laravel#291
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #291
Summary
Some AI providers (notably Anthropic) send tool call arguments under the `input` key instead of `arguments`. `PrismTool::toLaravelToolCall()` and `toLaravelToolResult()` only check for `arguments`, silently dropping all arguments when `input` is used.
The Bug
The Fix
Check `input` as a fallback when `arguments` is not present:
Applied to both `toLaravelToolCall()` and `toLaravelToolResult()`.
Consistency
This follows the same pattern used in PR #326 which fixed the identical issue in `DatabaseConversationStore`.
Changes