[0.x] Sync conversation state to StreamableAgentResponse after streaming#337
Open
svidskiy wants to merge 1 commit intolaravel:0.xfrom
Open
[0.x] Sync conversation state to StreamableAgentResponse after streaming#337svidskiy wants to merge 1 commit intolaravel:0.xfrom
svidskiy wants to merge 1 commit intolaravel:0.xfrom
Conversation
…AgentResponse When using streaming with conversational agents, the RememberConversation middleware sets conversationId on the StreamedAgentResponse via thenCallbacks, but the caller holds a StreamableAgentResponse where conversationId remains null. This syncs conversationId and conversationUser back to the StreamableAgentResponse after thenCallbacks complete, so callers can access $stream->conversationId. Fixes laravel#336
svidskiy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #336
StreamableAgentResponse::conversationIdis alwaysnullafter iterating a streaming conversational agent.The
RememberConversationmiddleware sets conversation state on the innerStreamedAgentResponseviathenCallbacks, but the outerStreamableAgentResponsethat the caller holds is never updated.This adds two lines after
thenCallbackscomplete ingetIterator()to sync the state back:Before:
$stream->conversationIdreturnsnullafter streaming.After:
$stream->conversationIdreturns the conversation UUID, matchingprompt()behavior.