fix: change operator to receive docling verify ssl#1817
Conversation
|
Caution Review failedFailed to post review comments WalkthroughThis PR adds configurable SSL certificate verification for external Docling Serve connections. A new ChangesDocling SSL Verification Support
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This pull request adds support for configuring SSL verification for the Docling service via a new
verifySsloption. The changes ensure that theDOCLING_SERVE_VERIFY_SSLenvironment variable is consistently set in both backend and Langflow components, and that this variable is included in all relevant configuration, defaults, and tests.Docling SSL verification configuration:
verifySslfield (default:false) to thedoclingsection invalues.yamland theDoclingSpecstruct in the operator API, allowing users to control SSL verification for Docling connections. [1] [2]DOCLING_SERVE_VERIFY_SSLenvironment variable based on theverifySslvalue, defaulting to"true"if not specified. [1] [2]verifySslvalue to theDOCLING_SERVE_VERIFY_SSLenvironment variable for both backend and Langflow components. [1] [2]Environment variable management:
DOCLING_SERVE_VERIFY_SSLto the list of required environment variables and ensured it has a default value of"false"in the operator's environment variable manager and related tests. [1] [2] [3] [4] [5]variablesToGetFromEnvironmentlists in both Helm values and operator code to includeDOCLING_SERVE_VERIFY_SSLso it is exposed to flows. [1] [2]These changes provide a consistent and configurable way to control SSL verification for Docling service connections across the deployment.
Summary by CodeRabbit