-
Notifications
You must be signed in to change notification settings - Fork 417
fix: update ssl verification for docling #1813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
638e356
82af609
d899064
4863abb
c0db998
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -150,6 +150,11 @@ stringData: | |
| {{- if and .Values.global.docling.scheme .Values.global.docling.host .Values.global.docling.port }} | ||
| DOCLING_SERVE_URL={{ printf "%s://%s:%v" .Values.global.docling.scheme .Values.global.docling.host .Values.global.docling.port | quote }} | ||
| {{- end }} | ||
| {{- if hasKey .Values.global.docling "verifySsl" }} | ||
| DOCLING_SERVE_VERIFY_SSL={{ ternary "true" "false" .Values.global.docling.verifySsl | quote }} | ||
| {{- else }} | ||
| DOCLING_SERVE_VERIFY_SSL="true" | ||
| {{- end }} | ||
|
Comment on lines
+153
to
+157
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Description: Compare DOCLING_SERVE_VERIFY_SSL defaults in Helm vs operator
echo "=== Helm backend-dotenv default when verifySsl key absent ==="
rg -n 'DOCLING_SERVE_VERIFY_SSL.*"true"' kubernetes/helm/openrag/templates/backend/
echo ""
echo "=== Operator env.go default for DOCLING_SERVE_VERIFY_SSL ==="
rg -n 'DOCLING_SERVE_VERIFY_SSL.*"false"' kubernetes/operator/internal/controller/env.goRepository: langflow-ai/openrag Length of output: 541 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "=== Helm backend-dotenv.yaml (around 148-160) ==="
nl -ba kubernetes/helm/openrag/templates/backend/backend-dotenv.yaml | sed -n '140,170p'
echo
echo "=== Operator env.go (around 70-110) ==="
nl -ba kubernetes/operator/internal/controller/env.go | sed -n '60,115p'
echo
echo "=== Operator env.go (around 135-170) ==="
nl -ba kubernetes/operator/internal/controller/env.go | sed -n '130,180p'Repository: langflow-ai/openrag Length of output: 174 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "=== Helm backend-dotenv.yaml (around 148-160) ==="
cat -n kubernetes/helm/openrag/templates/backend/backend-dotenv.yaml | sed -n '145,165p'
echo
echo "=== Operator env.go (around 70-115) ==="
cat -n kubernetes/operator/internal/controller/env.go | sed -n '70,115p'
echo
echo "=== Operator env.go (around 135-180) ==="
cat -n kubernetes/operator/internal/controller/env.go | sed -n '135,180p'Repository: langflow-ai/openrag Length of output: 5931 🏁 Script executed: rg -n "DOCLING_SERVE_VERIFY_SSL" .Repository: langflow-ai/openrag Length of output: 18841 Align 🤖 Prompt for AI Agents |
||
| # Langflow auth | ||
| {{- if .Values.langflow.auth.superuser }} | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default unknown
verify_sslvalues to secureTrue.This parser disables certificate verification for any string outside a tiny truthy allowlist. Because
verify_sslis a free-formStrInput, a typo, extra whitespace, blank value, or unresolved placeholder will silently turn TLS verification off for both Docling client paths.Suggested fix
def _get_verify_ssl(self) -> bool: """Determine whether to verify SSL certificates for Docling Serve. Returns: bool: True if SSL verification should be enforced, False otherwise. """ - verify = getattr(self, "verify_ssl", "true") + verify = getattr(self, "verify_ssl", True) if isinstance(verify, bool): return verify if isinstance(verify, str): - return verify.lower() in ("true", "1", "yes") + normalized = verify.strip().lower() + if normalized in {"false", "0", "no"}: + return False + return True return TrueAlso applies to: 293-304
🤖 Prompt for AI Agents