Skip to content

fix: remove clickhouse connect from Langflow image#1802

Open
lucaseduoli wants to merge 1 commit into
mainfrom
fix/remove_clickhouse_connect
Open

fix: remove clickhouse connect from Langflow image#1802
lucaseduoli wants to merge 1 commit into
mainfrom
fix/remove_clickhouse_connect

Conversation

@lucaseduoli

@lucaseduoli lucaseduoli commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

This pull request makes a minor change to the Dockerfile.langflow to address a dependency issue. Specifically, it ensures that the clickhouse-connect package is uninstalled after installing the required dependencies, likely to avoid conflicts or unnecessary bloat in the final image.

  • Uninstalls the clickhouse-connect package after the main dependencies are installed to prevent potential issues with this package in the runtime environment.

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated Docker image dependencies and package configuration to optimize the container build environment.

@lucaseduoli lucaseduoli self-assigned this Jun 8, 2026
@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

The Dockerfile.langflow RUN instruction for Langflow installation is updated to add uv to the pip install command and explicitly uninstall clickhouse-connect in the same step, ensuring the package does not appear in the final image runtime.

Changes

Langflow Docker Build Configuration

Layer / File(s) Summary
Langflow package installation update
Dockerfile.langflow
The pip install command now includes uv as an explicit package, and a follow-up pip uninstall -y clickhouse-connect removes that dependency from the final runtime image.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

bug

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change in the pull request - removing clickhouse-connect from the Langflow Dockerfile image.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/remove_clickhouse_connect

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added docker bug 🔴 Something isn't working. and removed bug 🔴 Something isn't working. labels Jun 8, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (2)
Dockerfile.langflow (2)

58-59: ⚡ Quick win

Add a post-uninstall dependency check.

On Line 59, uninstalling a transitive package without validating the environment can defer breakage to runtime. Add pip check in the same RUN chain so the image build fails fast if requirements are inconsistent.

Suggested diff
-    uv \
-    && pip uninstall -y clickhouse-connect
+    uv \
+    && pip uninstall -y clickhouse-connect \
+    && pip check
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Dockerfile.langflow` around lines 58 - 59, The Dockerfile currently
uninstalls a transitive package using the pip command shown as pip uninstall -y
clickhouse-connect; update that same RUN chain to run pip check immediately
after the uninstall so the image build fails early on inconsistent dependencies
— locate the RUN chain that includes the pip uninstall (the command with pip
uninstall -y clickhouse-connect) and append a pip check command in the same
shell sequence to validate installed packages before the layer completes.

58-58: ⚡ Quick win

Pin uv to a specific version for deterministic builds.

Line 58 currently installs a floating uv version, which can cause rebuild drift. Pin to a tested version (uv==x.y.z) to keep runtime and CI behavior reproducible.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Dockerfile.langflow` at line 58, The Dockerfile currently installs a floating
dependency "uv" which can cause non-deterministic builds; update the package
spec on the line containing "uv" to pin it to a tested, explicit version (e.g.,
change "uv" to "uv==x.y.z") so the image and CI are reproducible, and ensure any
corresponding requirements files or build docs are updated to match that exact
version.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@Dockerfile.langflow`:
- Around line 58-59: The Dockerfile currently uninstalls a transitive package
using the pip command shown as pip uninstall -y clickhouse-connect; update that
same RUN chain to run pip check immediately after the uninstall so the image
build fails early on inconsistent dependencies — locate the RUN chain that
includes the pip uninstall (the command with pip uninstall -y
clickhouse-connect) and append a pip check command in the same shell sequence to
validate installed packages before the layer completes.
- Line 58: The Dockerfile currently installs a floating dependency "uv" which
can cause non-deterministic builds; update the package spec on the line
containing "uv" to pin it to a tested, explicit version (e.g., change "uv" to
"uv==x.y.z") so the image and CI are reproducible, and ensure any corresponding
requirements files or build docs are updated to match that exact version.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d62d9eb1-842b-48ac-98c7-515859d25736

📥 Commits

Reviewing files that changed from the base of the PR and between 0ba97b1 and b010bff.

📒 Files selected for processing (1)
  • Dockerfile.langflow

@edwinjosechittilappilly edwinjosechittilappilly left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Hey is it a CVE fix? will it prevent langflow to load?

@github-actions github-actions Bot added the lgtm label Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug 🔴 Something isn't working. docker lgtm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants