feat: active task dialog#1739
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughCentralizes task dialog state in TaskContext with openTaskDialog/closeTaskDialog, renders TaskDialog from the provider, makes TaskDialog title status-aware and footer conditional, and wires Header, TaskNotificationMenu, and TaskErrorContent to openTaskDialog. ChangesShared Task Dialog Flow
sequenceDiagram
participant Header
participant NotificationMenu
participant ErrorContent
participant TaskProvider
participant TaskDialog
Header->>TaskProvider: openTaskDialog(taskId)
NotificationMenu->>TaskProvider: openTaskDialog(taskId)
ErrorContent->>TaskProvider: openTaskDialog(taskId)
TaskProvider->>TaskProvider: set taskDialogTaskId, set isTaskDialogOpen=true
TaskProvider->>TaskDialog: render(open=true, taskId)
TaskDialog->>TaskProvider: onOpenChange(false) / onClose
TaskProvider->>TaskProvider: set isTaskDialogOpen=false, clear taskDialogTaskId
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@frontend/components/task-dialog/task-dialog.tsx`:
- Around line 170-184: This footer button currently labeled "Cancel" only calls
onClose (in the Button rendered with props isCancelOnly, isRetrying,
showRetryActions, isCloudBrand), which is misleading; either wire it to perform
real task cancellation by invoking the actual cancel handler (e.g., call the
existing cancelTask/cancelIngestion function or dispatch the cancellation action
and handle isRetrying state) or rename the label to a non-action word like
"Close" or "Dismiss" and update its aria-label/tooltip accordingly so it clearly
only closes the dialog; ensure the change is applied where Button uses
onClose/isCancelOnly/isRetrying and update any related tests or accessibility
text.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 80b8f496-4f57-4d4a-ba95-d6b80e81538a
📒 Files selected for processing (6)
frontend/components/header.tsxfrontend/components/task-dialog/header.tsxfrontend/components/task-dialog/task-dialog.tsxfrontend/components/task-error-content.tsxfrontend/components/task-notification-menu.tsxfrontend/contexts/task-context.tsx
Summary by CodeRabbit
New Features
Improvements