Disable visual feedback for the password prompt#20
Open
xsmile wants to merge 1 commit intoladar:masterfrom
xsmile:disable-visual-feedback
Open
Disable visual feedback for the password prompt#20xsmile wants to merge 1 commit intoladar:masterfrom xsmile:disable-visual-feedback
xsmile wants to merge 1 commit intoladar:masterfrom
xsmile:disable-visual-feedback
Conversation
Keeping it enabled reveals the length of the password being entered.
Owner
|
Hi @xsmile I can appreciate not wanting the asterisks to appear, especially if someone else can see your screen. But disabling them by default doesn't seem like a good idea. Entering long, random/complex passwords or passphrases without that feedback means it will be that much harder to use. And that much more frustrating. Ideally you should be able to hide the asterisks, and/or reveal the characters typed using a special key combination. Ctrl+Alt+* seems like a good one for toggling the asterisks. In a perfect world we'd add text (ideally along the bottom of the screen), letting users know about the shortcut. Alternatively Ctrl+Alt+! could toggle the plaintext. Does that sound like it would work? Can you submit a PR which does that instead? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keeping it enabled reveals the length of the password being entered.