bugfixes: write proper csv and correct custom_header option#1
Open
bob-commits wants to merge 1 commit intolaconicwolf:masterfrom
Open
bugfixes: write proper csv and correct custom_header option#1bob-commits wants to merge 1 commit intolaconicwolf:masterfrom
bob-commits wants to merge 1 commit intolaconicwolf:masterfrom
Conversation
bob-commits
commented
Oct 10, 2019
bob-commits
commented
- The csv code didn't escape all wordlist characters so that the resulting csv file was corrupted (e.g. quote characters). This pull request uses the python csv library to handle the output format.
- Due to mistypings in the added custom_header option, the script was unable to start. This pull request fixes these mistypings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.