add_years function for adding new brackets#19
Open
michaelpkuhn wants to merge 3 commits intokylestahl:devfrom
Open
add_years function for adding new brackets#19michaelpkuhn wants to merge 3 commits intokylestahl:devfrom
michaelpkuhn wants to merge 3 commits intokylestahl:devfrom
Conversation
added 3 commits
March 13, 2023 17:06
…not sure if there's a better way for a package
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if you're still maintaining this, but I couldn't find a more active package for March Madness simulations
To add additional years, the brackets.json file needs to be updated, but it is not recommended to update it directly as a package.
I added a function to brackets.py that adds a schema validated dictionary to brackets_dict. This requires a new package. I added a requirements.txt, but I am not sure if there's a better way to add it for the package.