(feat) Add modal for MarketMate (in-progress) demonstration#33
Open
(feat) Add modal for MarketMate (in-progress) demonstration#33
Conversation
c0b0b12 to
9871d56
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demo projects
Summary
This pull request significantly expands and enhances the test coverage for the Marketmate project card and its gallery modal in the
WhoamiLiveProjectsTestsuite. It introduces comprehensive tests for the modal's behavior, navigation, and UI elements, as well as utility functions to support these tests. There are also minor updates to versioning and improvements to existing helper functions.Marketmate Gallery Modal and Project Card Testing:
Helper and Utility Function Enhancements:
has_tag_with_src_containing?/3andhas_tag_with_attribute?/3to facilitate DOM assertions for video and attribute presence in test trees.has_backdrop_close?/2helper to accept an event name, improving its flexibility and reusability. [1] [2] [3]General Improvements:
mix.exsfrom1.3.0to1.4.0.These changes improve the reliability and maintainability of the test suite, especially around interactive UI components.