Open
Conversation
….0-457-ga46d5732d9)
….40.0-787-g0f94c19331)
… freetype compatibility." This reverts commit bfccc58.
….40.0-795-gcbc694239b)
….40.0-1240-gb57e04d1c7)
…, and removed.
It was deprecated in m139, and gone in m140.
Milestone 139
-------------
* `SkFontMgr_New_FontConfig` with 1 parameter has been deprecated and will be removed in a future
release. Clients will need to call the other version providing an SkFontScanner (e.g.
`SkFontScanner_Make_FreeType()`)
Conflicts:
src/skia/Font.cpp
…favor of the `SkRecorder*` version.
Milestone 140
-------------
* `SkImage::isValid(GrRecordingContext*)` has been deprecated in favor of the `SkRecorder*` version.
To migrate do something like `image->isValid(ctx->asRecorder())`.
`SkImage::makeSubset(GrDirectContext*, ...)` has been deprecated in favor of the `SkRecorder*`
version. To migrate, do something like `image->makeSubset(ctx->asRecorder, ..., {})`
`SkImage::makeColorSpace(GrDirectContext*, ...)` has been deprecated in favor of the `SkRecorder*`
version. To migrate, do something like `image->makeColorSpace(ctx->asRecorder, ..., {})`
`SkImage::makeColorTypeAndColorSpace(GrDirectContext*, ...)` has been deprecated in favor of the
`SkRecorder*` version. To migrate, do something like
`image->makeColorTypeAndColorSpace(ctx->asRecorder, ..., {})`
In the case you are working with CPU-backed images, `skcpu::Recorder::TODO()` should work until
a `skcpu::Context` and `skcpu::Recorder` can be used properly.
…atrix.inverse()
m139:
bool setPolyToPoly(const SkPoint src[], const SkPoint dst[], int count);
m140:
bool setPolyToPoly(SkSpan<const SkPoint> src, SkSpan<const SkPoint> dst);
Before m140, only (deprecated):
[[nodiscard]] bool invert(SkMatrix* inverse) const;
Added in m140:
std::optional<SkMatrix> invert() const;
Old:
bool getSegment(SkScalar startD, SkScalar stopD, SkPath* dst, bool startWithMoveTo);
Newly added:
bool getSegment(SkScalar startD, SkScalar stopD, SkPathBuilder* dst, bool startWithMoveTo);
Old:
bool transform(const SkMatrix& matrix, SkRRect* dst) const;
Newly added:
std::optional<SkRRect> transform(const SkMatrix& matrix) const;
Old:
bool getBoundaryPath(SkPath* path) const;
Newly added:
SkPath getBoundaryPath() const;
was:
bool applyToPath(SkPath* dst, const SkPath& src) const;
m140:
bool applyToPath(SkPathBuilder* dst, const SkPath& src) const;
This reverts commit cd8af0c. Should not be needed in m140.
Signed-off-by: Hin-Tak Leung <htl10@users.sourceforge.net>
src/skia/Matrix.cpp:1562:13: error: return type 'Tuple<int, int>' must match previous return type
'Tuple<float &, float &>' when lambda expression has unspecified explicit return type
1562 | return py::make_tuple(-1, -1);
| ^
1 error generated.
Signed-off-by: Hin-Tak Leung <htl10@users.sourceforge.net>
Fixes kyamagu#350 See kyamagu#350 Segfault on pytest exit in CI against pybind11 3.0.1 This is a workaround. See upstream issues: pybind/pybind11#5976 [BUG]: Crash due to invalid free during cleanup, if any enum is registerd, due to attempting to free a string literal pybind/pybind11#5991 [BUG]: segfault at exit since upgrading to 3.0.x, probably due to "Make wrapped C++ functions pickleable" (pybind/pybind11#5580) Signed-off-by: Hin-Tak Leung <htl10@users.sourceforge.net>
…Format and VkImageLayout Signed-off-by: Hin-Tak Leung <htl10@users.sourceforge.net>
Signed-off-by: Hin-Tak Leung <htl10@users.sourceforge.net>
src/skia/Matrix.cpp:1562:13: error: return type 'Tuple<int, int>' must match previous return type
'Tuple<float &, float &>' when lambda expression has unspecified explicit return type
1562 | return py::make_tuple(-1, -1);
| ^
1 error generated.
Signed-off-by: Hin-Tak Leung <htl10@users.sourceforge.net>
Fixes kyamagu#350 See kyamagu#350 Segfault on pytest exit in CI against pybind11 3.0.1 This is a workaround. See upstream issues: pybind/pybind11#5976 [BUG]: Crash due to invalid free during cleanup, if any enum is registerd, due to attempting to free a string literal pybind/pybind11#5991 [BUG]: segfault at exit since upgrading to 3.0.x, probably due to "Make wrapped C++ functions pickleable" (pybind/pybind11#5580) Signed-off-by: Hin-Tak Leung <htl10@users.sourceforge.net>
…Format and VkImageLayout Signed-off-by: Hin-Tak Leung <htl10@users.sourceforge.net>
Signed-off-by: Hin-Tak Leung <htl10@users.sourceforge.net>
src/skia/Matrix.cpp:1562:13: error: return type 'Tuple<int, int>' must match previous return type
'Tuple<float &, float &>' when lambda expression has unspecified explicit return type
1562 | return py::make_tuple(-1, -1);
| ^
1 error generated.
Signed-off-by: Hin-Tak Leung <htl10@users.sourceforge.net>
See actions/runner-images#13046 macOS 13 is fully unsupported by December 4th 2025 for GitHub.
See actions/runner-images#13046 macOS 13 is fully unsupported by December 4th 2025 for GitHub.
See actions/runner-images#13046 macOS 13 is fully unsupported by December 4th 2025 for GitHub.
See actions/runner-images#13046 macOS 13 is fully unsupported by December 4th 2025 for GitHub.
Revert "Skip pybind11 3.0.0 until it get fixed (waiting for 3.0.1)" This reverts commit 443a499.
Revert "Make artefacts available even when pytest fails." This reverts commit a057e3c.
Revert "Make artefacts available even when pytest fails." This reverts commit a057e3c.
Revert "Make artefacts available even when pytest fails." This reverts commit a057e3c.
…0.40.0-1582-g05dcf6678e)
…0.40.0-1870-gc695cba6ed)
m140-public includes everything in m139-public. Merge remote-tracking branch 'origin/m139-public' into m140-public
Merge remote-tracking branch 'origin/m140-public' into m141-public
Merge remote-tracking branch 'origin/m141-public' into m142-public
Revert "Make artefacts available even when pytest fails." This reverts commit a057e3c.
Merge remote-tracking branch 'origin/m142-public' into m143-public
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expect to segfault at end of ci due to pybind11 issue (#350). Also macos-13 seems to have been withdrawn by github in the last few months. Otherwise quite similar to m138.