Fix state handling and inventory scan logic in weaponRefine plugin#1
Open
kw4k wants to merge 1 commit into
Open
Fix state handling and inventory scan logic in weaponRefine plugin#1kw4k wants to merge 1 commit into
kw4k wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
A-za-ztoA-Za-zto prevent unintended character ranges.eq/ne) with numeric operators (==/!=) for comparisons againstTRUE/FALSEand state constants to make control flow consistent.findAndSetWeaponto resetweaponInInventoryandweaponSetStatusbefore scanning and to scan the entire inventory instead of aborting on the first non-matching entry.setRefineAmountaccept the argument viamy ($arg)and assign it to the global$refineAmount, and replaceundef $weaponInInventorywith explicitFALSEto keep state consistent.Testing
perl -c weaponRefine.pl, which could not complete because OpenKore runtime modules (e.g.Plugins.pm) are not available in the current environment and reported missing modules in@INC(so the check failed here).Codex Task