-
Notifications
You must be signed in to change notification settings - Fork 9
Migrate to Deno LTS #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Deno LTS #119
Conversation
- Replaced package.json with deno.json - Migrated build scripts from bash/tsx to Deno + esbuild (tools/build.ts) - Updated source code imports to include .ts extensions and use npm: specifiers - Migrated tests from Jest to Deno native test runner (@std/testing) - Replaced Node.js globals (process, Buffer) with node: imports or Deno equivalents - Fixed linting issues and updated types - Configured esbuild with @luca/esbuild-deno-loader for resolving npm dependencies
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
Defines rules for: - No unauthorized PR submissions. - Atomic commits.
- Replaces `actions/setup-node` with `denoland/setup-deno@v2` - Updates node-based commands (npm) to deno task commands - Fixes `push-ci.yml` and `pages.yml` to use Deno environment
- Replaces `actions/setup-node` with `denoland/setup-deno@v2` - Updates node-based commands (npm) to deno task commands - Fixes `push-ci.yml` and `pages.yml` to use Deno environment
Adds "ci": "deno task lint && deno task test" to deno.json to support CI workflows.
- Exclude `public/` from lint/fmt in `deno.json` to fix CI timeout/failures. - Format all code with `deno fmt`. - Update `README.md` with Deno instructions. - Update `AGENTS.md` with strict CI passing rule.
- Migrate `Deno.*` usage to `node:process` equivalents. - Replace `glob` package with `jsr:@std/fs/expand-glob`. - Reformat code to default Deno style (removing custom formatting rules). - Exclude `public/` from lint/fmt in `deno.json`. - Remove `glob` dependency.
- Refactor: Use Node.js globals and expandGlob (includes formatting changes to pass lint). - Update AGENTS.md with stricter Atomic Commit rules.
- Migrate Deno.* to process.* - Replace glob with expandGlob - Update deno.json - Apply deno fmt (all files) - Update README.md and AGENTS.md
Atomic commits included in this push: 1. Refactor: Use Node.js globals and expandGlob (includes formatting) 2. Update README for Deno migration 3. Update AGENTS.md with stricter rules
This PR migrates the entire project infrastructure from Node.js (v24) to Deno (v2.5+). Key changes include:
package.jsonandpackage-lock.jsonare removed.deno.jsonis introduced to manage tasks, imports, and configuration.mise.tomlis updated to includedeno.tools/build.bashscript is replaced bytools/build.ts, a TypeScript script running directly in Deno that invokesesbuildwith the@luca/esbuild-deno-loaderplugin to bundle the application for the browser.src/,lib/, andtools/are updated to use explicit.tsextensions. Node.js globals likeprocessandBufferare imported fromnode:specifiers where necessary, or replaced with standard Web APIs (globalThis).jestis removed. Tests insrc/test/are rewritten to use Deno'sDeno.testand the@std/expect,@std/testing/mock, and@std/testing/timelibraries. Logic in tests likecache-holder.test.tsandthrottled-invoker.test.tsis adjusted to work correctly with Deno'sFakeTime.deno lintanddeno fmt.Verification:
deno task build:tspasses and generates bundles inpublic/.deno testpasses all tests insrc/test/.deno lintreports no errors (after fixes).build:json:*tasks fail as expected due to missinglocal.json(user instruction to ignore).PR created automatically by Jules for task 4852866305107402981 started by @kui