Remove kskubemanager dependency and replace with kubemanager in tracer_factory#729
Remove kskubemanager dependency and replace with kubemanager in tracer_factory#729
Conversation
…r_factory Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
📝 WalkthroughWalkthroughThe PR updates the Kubernetes manager dependency to a newer commit version and removes the legacy KsKubeManager implementation, migrating the tracer factory to use a new kubemanager package for Kubernetes management. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
go.mod (1)
461-461: Document a long-term strategy for this fork dependency.The fork carries custom implementations (e.g.,
NewKubeManager()constructor andexternalCollectionsbypass pattern) that are not present in upstream inspektor-gadget (including latest releases v0.49.0 and v0.49.1). Since equivalent changes are not merged upstream, maintain clear documentation on whether these changes should be upstreamed, consolidated into the fork long-term, or addressed through an alternative approach to reduce ongoing maintenance burden.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@go.mod` at line 461, Document the long-term strategy for the forked dependency replacement (the replace directive pointing to matthyx/inspektor-gadget) by adding a short design note describing whether the custom changes (notably the NewKubeManager() constructor and the externalCollections bypass pattern) will be upstreamed, maintained in the fork, or replaced with alternatives; include a summary of all diffs from upstream, a migration/maintenance plan (how to reconcile upstream releases and when to sync), and an owner/decision point for future changes so maintainers can follow a clear process.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@go.mod`:
- Line 461: Document the long-term strategy for the forked dependency
replacement (the replace directive pointing to matthyx/inspektor-gadget) by
adding a short design note describing whether the custom changes (notably the
NewKubeManager() constructor and the externalCollections bypass pattern) will be
upstreamed, maintained in the fork, or replaced with alternatives; include a
summary of all diffs from upstream, a migration/maintenance plan (how to
reconcile upstream releases and when to sync), and an owner/decision point for
future changes so maintainers can follow a clear process.
ℹ️ Review info
Configuration used: defaults
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (3)
go.modpkg/containerwatcher/v2/tracers/tracer_factory.gopkg/kskubemanager/kubemanager.go
💤 Files with no reviewable changes (1)
- pkg/kskubemanager/kubemanager.go
Summary by CodeRabbit