tooling(srctl): add README describing purpose and usage#180
tooling(srctl): add README describing purpose and usage#180Pnkcaht wants to merge 1 commit intokubernetes:mainfrom
Conversation
Signed-off-by: pnkcaht <samzoovsk19@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Pnkcaht The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @Pnkcaht! |
|
Hi @Pnkcaht. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
mtardy
left a comment
There was a problem hiding this comment.
Hey thanks for taking the time to do this but I feel overall we could really improve this README, the information is repeated multiple times, it sounds quite diluted. I don't think it's useful under this form.
I don't know if you generated this using AI and my initial issue but I feel it would be better if you tried to do this manually. Writing a concise and information dense README would be appropriate for this.
Quickly being able to understand, what is this tool, what problem it solves exactly, for who, and how to use it in 5min maybe showing outputs and command line interaction would be better than this.
| This tool is primarily intended for: | ||
|
|
||
| - Kubernetes Security Response Committee (SRC) members | ||
| - Contributors involved in CVE publication and coordination |
There was a problem hiding this comment.
could you remove this line, it's only for SRC people, but this is not the only problem, see the general feedback
|
|
||
| It was created to standardize and simplify the CVE publication workflow, while enabling the generation of structured vulnerability metadata that can be consumed by downstream security tooling. | ||
|
|
||
| --- |
There was a problem hiding this comment.
could you remove the --- in the doc?
| @@ -0,0 +1,59 @@ | |||
| # srctl | |||
|
|
|||
| `srctl` is a small CLI tool used by Kubernetes Security Response Committee (SRC) members to publish official CVE announcements. | |||
There was a problem hiding this comment.
Could you wrap all lines to 80 chars approx, that makes review easier, you can use vim with gq for that
|
I see from your GitHub profile that you have been opening a lot of PRs in various repositories and organizations on the same day. I understand why you may be excited that AI can multiply your impact but I'd suggest focusing on smaller subset of tasks and trying to propose actual good contributions. Blasting projects with contributions like that really doesn't help imho. Most of the time when we open |
I understand, I don't judge. In fact, I work in the Docker and Grafana ecosystem, and my PRs range from small to large, without errors. But I confess that in Kubernetes I used AI to facilitate and accelerate the process, even knowing that AI makes mistakes (and that's what happened). I will correct the problems and do it the same way I do in Docker and Grafana. |
What I did
sig-security-tooling/srctldirectorysrctlRelated issues
README.mdto sig-security-tooling/srctl #176