Include description for allowed enum values for elements within a slice#566
Open
tnozicka wants to merge 1 commit intokubernetes:masterfrom
Open
Include description for allowed enum values for elements within a slice#566tnozicka wants to merge 1 commit intokubernetes:masterfrom
tnozicka wants to merge 1 commit intokubernetes:masterfrom
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tnozicka The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XS
tnozicka
force-pushed
the
openapi-slice-enums
branch
from
75a0c13 to
bf9229c
Compare
tnozicka
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
tnozicka
force-pushed
the
openapi-slice-enums
branch
from
bf9229c to
e7dcd5b
Compare
tnozicka
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Author
|
/cc jefftree alexzielenski |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
k8s-ci-robot
added
the
lifecycle/stale
Author
|
/remove-lifecycle stale |
k8s-ci-robot
removed
the
lifecycle/stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds extra enum description in the openapi when wrapped within a slice. The listed enum values in the descriptions are the way that our website reference uses to present enums. (The api reference generator unfortunately can't read the Enum property.)