✨ Add metrics and scale test#185
Conversation
✅ Deploy Preview for node-readiness-controller ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Karthik-K-N The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
needs-rebase
Karthik-K-N
force-pushed
the
scale-test-monitor
branch
from
4a0dcda to
f594ebb
Compare
k8s-ci-robot
removed
the
needs-rebase
Karthik-K-N
force-pushed
the
scale-test-monitor
branch
from
f594ebb to
e84c8c2
Compare
|
|
||
| .PHONY: etcd-size | ||
| etcd-size: ## Monitor etcd size for NodeReadinessRules | ||
| @$(SCALE_DIR)/etcd-size.sh |
There was a problem hiding this comment.
I think the file is missing
There was a problem hiding this comment.
No More required, I removed it.
| "resourceVersion", rule.ResourceVersion) | ||
| // continue with other rules | ||
| } else { | ||
| r.updateNodesByStateMetrics(ctx, rule) |
There was a problem hiding this comment.
question: shouldn't this be latestRule?
There was a problem hiding this comment.
Yes, I have updated it.
Karthik-K-N
force-pushed
the
scale-test-monitor
branch
from
e84c8c2 to
3eeece0
Compare
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@Karthik-K-N: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
Description
This PR adds metrics and scale tests using KWOK
Related Issue
Type of Change
/kind feature
Testing
Checklist
make testpassesmake lintpassesDoes this PR introduce a user-facing change?
Adds
Doc #(issue)