fix: replace print() with structured logging in HTTPS server#191
Open
adarshkumar23 wants to merge 1 commit intokubeflow:mainfrom
Open
fix: replace print() with structured logging in HTTPS server#191adarshkumar23 wants to merge 1 commit intokubeflow:mainfrom
adarshkumar23 wants to merge 1 commit intokubeflow:mainfrom
Conversation
Replace all raw print() statements with Python logging module using proper log levels (INFO, ERROR) and format strings. This enables production-grade log management with configurable levels, timestamps, and integration with log aggregation systems. Signed-off-by: Adarsh Kumar <adarsh23072005@gmail.com> Signed-off-by: adarshkumar23 <131923092+adarshkumar23@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace all raw
print()statements inserver-https/app.pywith Python'sloggingmodule using proper log levels and format strings.Problem
The HTTPS server uses bare
print()for all output — errors, info, and debug messages are all treated identically. This makes it impossible to:Changes
loggingmodule withbasicConfig(timestamped, leveled format)[ERROR]prints →logger.error()[TOOL]/[CHAT]prints →logger.info()logger.info()%sformat strings instead of f-strings (logging best practice for lazy evaluation)Files Changed
server-https/app.py— 21 print statements → structured logging