perf: Move SentenceTransformer to module level to prevent reload on every query#180
Open
24f3005089 wants to merge 2 commits intokubeflow:mainfrom
Open
perf: Move SentenceTransformer to module level to prevent reload on every query#18024f3005089 wants to merge 2 commits intokubeflow:mainfrom
24f3005089 wants to merge 2 commits intokubeflow:mainfrom
Conversation
…very query Signed-off-by: 24f3005089 <24f3005089@ds.study.iitm.ac.in>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #178
Summary
This PR fixes a performance issue where the
SentenceTransformermodel was being reloaded from disk on every search request, causing 500ms-2s latency per call.Changes
encoder = SentenceTransformer(EMBEDDING_MODEL)initialization from insidemilvus_search()function to module levelserver/app.pyandserver-https/app.pyImpact
search_kubeflow_docsmay be invoked multiple times per conversation turnTesting
Code change only - verified syntax and logic. The model initialization now happens at module import time, and the encoder variable is reused across all function calls.