fix(manifests): replace live Pod dump with proper Deployment in milvus-deployment.yaml#172
Open
zong0728 wants to merge 1 commit intokubeflow:mainfrom
Open
Conversation
…s-deployment.yaml The file was a kubectl-exported Pod status snapshot (kind: Pod) instead of a declarative Deployment manifest. It contained cluster-specific runtime fields that make it non-applicable and misleading: - kind: Pod (not Deployment) with a ReplicaSet-generated pod name - Cluster-specific metadata: uid, resourceVersion, ownerReferences - nodeName pinned to a specific node IP (10.0.10.183) - Entire status block with live containerIDs and pod IPs - Auto-injected serviceaccount projected volume Running 'kubectl apply -f manifests/milvus-deployment.yaml' on any cluster would fail or produce unexpected behaviour. Replace with a clean Deployment manifest that: - Uses kind: Deployment with selector and replicas - Keeps the three-container spec (milvus, etcd, minio) with correct images, env vars, ports, probes, and volume mounts - Removes all cluster-runtime fields Signed-off-by: Shengzhong Guan <guan@cmu.edu> Made-with: Cursor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #171
manifests/milvus-deployment.yamlcontains a rawkubectl get pod -o yamlexport from a live cluster instead of a declarative Deployment manifest.
Running
kubectl apply -f manifests/milvus-deployment.yamlfails on anycluster other than the original.
Root Cause
The file was committed as a live Pod state snapshot with cluster-specific
runtime fields that cannot be reproduced elsewhere:
kind: Podwith a ReplicaSet-generated name (milvus-standalone-final-5cb655b8d6-6ngrn)uid,resourceVersion,ownerReferencespointing to a deleted ReplicaSetnodeName: 10.0.10.183pinning the Pod to a specific node IPstatusblock with livecontainerIDhashes, pod IPs, and timestampskube-api-access-2hjlpprojected serviceaccount volumeFix
Replace with a clean
Deploymentmanifest that preserves the three-containerspec (milvus, etcd, minio) with correct images, env vars, ports, probes, and
volumes, while removing all cluster-runtime fields.
Testing
kubectl apply --dry-run=client -f manifests/milvus-deployment.yamlpasses on a clean clusterChecklist