Skip to content

fix(mcp-server): use double-checked locking to prevent race condition in _init() #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zong0728 wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −4
Open

fix(mcp-server): use double-checked locking to prevent race condition in _init() #170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions kagent-feast-mcp/mcp-server/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import threading

from fastmcp import FastMCP
from pymilvus import MilvusClient
from sentence_transformers import SentenceTransformer
Expand All @@ -13,14 +15,18 @@

model: SentenceTransformer = None
client: MilvusClient = None
_init_lock = threading.Lock()


def _init():
"""Initialize model and client using double-checked locking to prevent race conditions."""
global model, client
if model is None:
model = SentenceTransformer(EMBEDDING_MODEL)
if client is None:
client = MilvusClient(uri=MILVUS_URI, user=MILVUS_USER, password=MILVUS_PASSWORD)
if model is None or client is None:
with _init_lock:
if model is None:
model = SentenceTransformer(EMBEDDING_MODEL)
if client is None:
client = MilvusClient(uri=MILVUS_URI, user=MILVUS_USER, password=MILVUS_PASSWORD)


@mcp.tool()
Expand Down