fix(pipelines): guard against ZeroDivisionError in chunk_and_embed_incremental when chunk list is empty#164
Open
Kunal-Somani wants to merge 1 commit intokubeflow:mainfrom
Conversation
…cremental The incremental pipeline has the same ZeroDivisionError crash as kubeflow-pipeline.py (fixed in PR kubeflow#149, issue kubeflow#148). When RecursiveCharacterTextSplitter returns an empty chunk list, the print statement divides by len(chunks) == 0, crashing the entire incremental KFP run. Add the same empty-chunk guard already applied in PR kubeflow#149, consistent with the existing short-content guard pattern in both pipelines. Fixes kubeflow#163 Signed-off-by: Kunal <kunal120222@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #163
chunk_and_embed_incrementalinpipelines/incremental-pipeline.pyhas the sameZeroDivisionErrorcrash askubeflow-pipeline.py, fixed in PR #149 (issue #148) — but the incremental pipeline was not addressed by that fix.Root Cause
The incremental pipeline applies identical aggressive regex cleaning (Hugo frontmatter, HTML tags, URLs). A document can pass the
< 50char content guard but produce zero chunks after splitting. The print statement on the next line divides bylen(chunks) == 0, crashing the entire incremental KFP run.Affected Line
Fix
Added the same empty-chunk guard already applied in PR #149:
Checklist