Add support for new locales - Update monthly.js#33
Open
jefferson wants to merge 2 commits intokthornbloom:masterfrom
Open
Add support for new locales - Update monthly.js#33jefferson wants to merge 2 commits intokthornbloom:masterfrom
jefferson wants to merge 2 commits intokthornbloom:masterfrom
Conversation
Hi! Sorry about make commit in this way, but I didn't see any instruction about how make contributions here.
Now we have support for locales :)
We can use:
$('#mycalendar2').monthly({monthNames: 'pt-br'})
Default is 'en'.
jefferson
changed the title
Add today as key in locale const and add check if options is undefined.
Owner
|
Thank you! I will check this out & merge it in soon |
Contributor
|
We should implement this using Intl.DateTimeFormat for both the short month name and short weekday names, with fallback to English for the few modern browsers (Safari desktop) that don't yet support that standard. That way we don't have to carry all of these localized arrays in the code. Similarly, options.weekStart should be a number, not an English abbreviation. Edit: I made the changes described above in pull request #41. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Sorry about make commit in this way, but I didn't see any instruction about how make contributions here.
Now we have support for locales :)
We can use:
$('#mycalendar2').monthly({monthNames: 'pt-br'})
Default is 'en'.