Feature/zoo 480 clear command approval buttons on auto exec#107
Merged
krzychdre merged 1 commit intoJun 17, 2026
Merged
Conversation
…c (#480) When a command/tool ask is auto-approved or auto-denied, the old flow added the ask message (showing approval buttons) and then posted a separate clearApprovalButtons message. The extension-host -> webview channel is fire-and-forget, so the clear could arrive before React rendered the buttons, leaving them stuck on-screen. Resolve checkAutoApproval() before adding the message and stamp isAnswered:true on it for immediate approve/deny; the webview's button-setup effect early-returns on isAnswered, so the buttons never appear. Add a clearApprovalButtons useCallback in ChatView shared by the click handlers, a pulsing dot on the running-command indicator, and a module-level statusCache in CommandExecution so a component mounting after the "started" event can recover the running status. Our ask() logic lives in TaskAskSay (not Task), so the backend change is hand-adapted there; the new backend test is rewired to the askSay harness. Ported from Zoo-Code PR #480 (cb3e93d52). Co-authored-by: Andrew Schmeder <149117631+awschmeder@users.noreply.github.com> Co-authored-by: Naved Merchant <naved.merchant@gmail.com>
krzychdre
force-pushed
the
feature/zoo-480-clear-command-approval-buttons-on-auto-exec
branch
from
98251af to
9037c2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.