Google Maps API V3 integration and fixed mixed content warning for SSL only sites#1
Open
jarvelov wants to merge 3 commits into
Open
Google Maps API V3 integration and fixed mixed content warning for SSL only sites#1jarvelov wants to merge 3 commits into
jarvelov wants to merge 3 commits into
Conversation
Owner
|
Thank you! This is great. I had a change to make the static map and link agnostic in my uncommitted version as well as a couple of other changes. I still need to review the maps js method and merge. |
Author
|
Hey cool! Saw the update and the protocol agnostic changes are very welcome! Give me a shout if you find any bugs or unexpected behaviour. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey!
To begin with, this plugin is really awesome so I've updated it with an option to display a non-static google map using Google Maps API V3 to be able to navigate around the map, zoom and change map type.
Working example here: Link
show="location" is used here to only display the map.
I've reused the settings for zoom, map height/width as well as the $geo_pretty_coords variable.
Also I've made the plugin enqueue the script/styles files using plugins_url() instead of the WP_PLUGIN_URL constant to serve files using the correct protocol used by the site, otherwise a mixed content warning was shown on SSL only sites. The static map option uses a protocol agnostic URL now, to ensure that SSL is used when needed.