Add support for method output port splitting #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krame505
commented
Jan 9, 2026
| filterZeroWidthPorts _ _ = error "filterZeroWidthPorts: non-empty port names list" | ||
|
|
||
| -- Helper class to conditionally convert Bit 0 to () | ||
| class NonEmptyBits n pb | n -> pb where |
Owner
Author
There was a problem hiding this comment.
@nanavati thinks this type class should have a different name. I'm unsure what to call it, though - maybeFilterEmptyBits? But that name sort of implies that we are filtering a tuple of Bit ns, while this actually deals with turning just a single Bit n into a ().
krame505
force-pushed
the
split-output-ports
branch
2 times, most recently
from
1566d62 to
500a1d6
Compare
krame505
force-pushed
the
split-output-ports
branch
from
58f9b23 to
8ea4ba6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is based on the input port splitting branch on my fork of bsc, for the sake of reviewing without seeing the changes from B-Lang-org#729.