upgrades/refactoring#10
Open
silannisik wants to merge 20 commits into
Open
Conversation
…ixed path to Java executable
… option for docker build
…authenticate/sub/pub, removed unused functions
… sources/resources properties from pom
Made stream name variable
|
|
||
| ARG IMAGE_VERSION | ||
|
|
||
| ARG image_version |
There was a problem hiding this comment.
I would keep the uppercase ARG names. I believe in docker files it is the more popular style.
rutgerc-klarrio
approved these changes
Jan 24, 2023
rutgerc-klarrio
left a comment
rutgerc-klarrio
left a comment
There was a problem hiding this comment.
I understand that it is example code, but it might still be worth it to look at using a logging library iso using print statements.
gert-verbruggen-klarrio
left a comment
gert-verbruggen-klarrio
left a comment
Contributor
There was a problem hiding this comment.
See the remarks of Rutger about the uppercase IMAGE_VERSION and the logger.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
We've been using this repository for onboarding new teams on DSH.
The changes we made to the repo are included in this PR.